Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the fake schedule is a tibble #43

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Make sure the fake schedule is a tibble #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd262d5
Make sure the fake schedule is a tibble
mrcaseb Jan 19, 2024
ddccf8f
news bullet
mrcaseb Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: nflseedR
Title: Functions to Efficiently Simulate and Evaluate NFL Seasons
Version: 1.2.0
Version: 1.2.0.9000
Authors@R: c(
person("Lee", "Sharpe", role = c("aut", "cph")),
person("Sebastian", "Carl", , "[email protected]", role = c("cre", "aut"))
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# nflseedR (development version)

* Fixed error in `simulate_nfl()` where it crashes because the "fake schedule" isn't a tibble. (#43)

# nflseedR 1.2.0

* `simulate_nfl()` gained the new argument `sim_include` to allow more access to what is actually being simulated. This makes it possible skip playoff simulation or the (possibly heavy) computation of draft order. (#34)
Expand Down
2 changes: 1 addition & 1 deletion R/simulate_nfl.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ simulate_nfl <- function(nfl_season = NULL,
".csv?raw=true"
)
tryCatch({
schedule <- data.table::fread(fn)
schedule <- data.table::fread(fn) %>% tibble::as_tibble()
cli::cli_alert_info("No actual schedule exists for {.val {nfl_season}}, using fake schedule with correct opponents.")
}, error = function(cond) {
cli::cli_abort("Unable to locate a schedule for {.val {nfl_season}}")
Expand Down
Loading