Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set width of logo columns in summary method #44

Merged
merged 1 commit into from
Jun 19, 2024
+4 −2
Merged

set width of logo columns in summary method #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: nflseedR
Title: Functions to Efficiently Simulate and Evaluate NFL Seasons
Version: 1.2.0.9000
Version: 1.2.0.9001
Authors@R: c(
person("Lee", "Sharpe", role = c("aut", "cph")),
person("Sebastian", "Carl", , "[email protected]", role = c("cre", "aut"))
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# nflseedR (development version)

* Fixed error in `simulate_nfl()` where it crashes because the "fake schedule" isn't a tibble. (#43)
* The `summary` method `summary.nflseedR_simulation()` explicitly sets the columns width of the logo column because those columns are hidden in some unclear scenarios.

# nflseedR 1.2.0

Expand Down
3 changes: 2 additions & 1 deletion R/summary_nflseedR.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ summary.nflseedR_simulation <- function(object, ...){
gt::ends_with("won_conf") ~ gt::px(60),
gt::ends_with("won_sb") ~ gt::px(60),
gt::ends_with("draft1") ~ gt::px(60),
gt::ends_with("draft5") ~ gt::px(60)
gt::ends_with("draft5") ~ gt::px(60),
gt::ends_with("team") ~ gt::px(60)
) %>%
gt::cols_align(
align = "right",
Expand Down
Loading