Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allocators from ntirpc_pkg_params #222

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

nuzhatfathima
Copy link

Directly using malloc and friends should be better than having our own
functions to trace memory allocations using mtrace/muntrace etc.

(cherry picked from commit f6cdb2c)

Directly using malloc and friends should be better than having our own
functions to trace memory allocations using mtrace/muntrace etc.

(cherry picked from commit f6cdb2c)
Copy link
Collaborator

@dang dang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I agree with this. Allowing the caller to provide allocators (as Ganesha does) is one of the API guarantees of ntirpc. This seems like a regression. Why would it be needed?

Copy link
Member

@ffilz ffilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants