-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation Review PR #3
Conversation
Co-authored-by: David Choi <[email protected]> Co-authored-by: Hugo Dias <[email protected]>
I've read through all of this, and it all looks great. I just have one suggestion (which may already be in the pipeline), which is that the logic in const storageActions = {
'upload/': {
'*': {
'IMPORT',
}
}
} And then you could pass that into the generic const storageSemantics = sematics(storageActions); and the You've probably already thought of this, but it's my main suggestion for improvement at the mo. |
Co-authored-by: Hugo Dias <[email protected]>
I've just read the documentation additions to the README, which look great. Reading that, it's given me a thought, which is that it would be nice to allow the CLI commands to accept the private key as a path to a file, so that (1) the user doesn't have to go through the step of copying the value out of their private key file, and (2) their private key isn't stored in their shell history. So, e.g. The user could just pass the key file contents as an argument themselves using some shell trickery. And there's also the complication that if we implement it then we have to consider the possibility of the key file being encrypted. So maybe it's not worth it. But it might be nice to have this option as a convenience and to encourage a more secure usage. |
already made an issue about this please check it out and add feedback there #11 |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hugo Dias <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created this PR to capture initial feedback on UCAN library implementation