DRAFT: Attempting to get unit tests to build. Concurrency logic is bad! [DO NOT MERGE] #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obably all wrong for all these locations modified. I commented out the final class related tests because that logic needs to be fixed too, before we can create the AsamStaticRemoteDataSource mock data source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concurrency logic is probably all wrong for all these locations modified. I commented out the final class related tests because that logic needs to be fixed too, before we can create the AsamStaticRemoteDataSource mock data source
Need to update to latest async/await syntax and update unit tests that are impacted ... we have a lot of warnings to sort out. I'm not sure if these UI tests will actually work as is.
@MainActor(not sure on the implications for that yet)