Skip to content

Commit

Permalink
CODA-OSS removed EncodedStringView (#688)
Browse files Browse the repository at this point in the history
* Squashed commit of the following:

commit e706d7eef95059373d6d95adb0240baf202d4762
Author: Dan Smith <[email protected]>
Date:   Mon Apr 18 13:16:01 2022 -0400

    some NITRO unit-tests don't work in "externals"

commit 05fc1f8d2b499d58e79a3fc4dc7961f88fb290bf
Author: Dan Smith <[email protected]>
Date:   Mon Apr 18 12:35:39 2022 -0400

    account for change to nitf::MemorySource

commit 01d65e595015b143007ad1c414d68bed41b0eb65
Author: Dan Smith <[email protected]>
Date:   Mon Apr 18 12:25:00 2022 -0400

    Update ReleaseNotes.md

commit 5296635b2c7a02d9b632568ff8f274df69c0239d
Author: Dan Smith <[email protected]>
Date:   Mon Apr 18 12:17:55 2022 -0400

    latest from "nitro"

commit 543bf38718e98f81b9a43d3299941243ab59f7a5
Author: Dan Smith <[email protected]>
Date:   Mon Apr 18 12:16:02 2022 -0400

    latest from coda-oss

commit f8fb45a1ef2b0c766a8fff532fc35ce48bae2be3
Merge: 043d37c66 844a356ba
Author: Dan Smith <[email protected]>
Date:   Mon Apr 18 12:09:02 2022 -0400

    Merge branch 'master' into develop/update-externals

commit 043d37c664378bd523c86e23d81f594d7f165b62
Author: Dan Smith <[email protected]>
Date:   Thu Feb 24 08:26:22 2022 -0500

    unit tests that don't work in "externals"

commit 2df69b20f74ac2b56e4e07c5e74a7c226230faf3
Author: J. Daniel Smith <[email protected]>
Date:   Wed Feb 23 21:30:32 2022 -0500

    imageCompression() now returns an "enum"

commit b378acef90d1bcee7b3844ec830b5a10f68ff9a6
Author: Dan Smith <[email protected]>
Date:   Wed Feb 23 17:28:50 2022 -0500

    latest from "nitro"

commit cc10dba53875a84f58f43321279fe67d3b12735c
Author: Dan Smith <[email protected]>
Date:   Wed Feb 23 17:23:35 2022 -0500

    latest from coda-oss

commit c08a0cebb45496c10efc929e65f646f8ba3c182d
Author: Dan Smith <[email protected]>
Date:   Wed Feb 23 13:45:48 2022 -0500

    latest from coda-oss

commit 4ee8337e5b0840065ba35fe85c3ee929593a1ece
Author: Dan Smith <[email protected]>
Date:   Wed Feb 9 11:44:59 2022 -0500

    latest from "nitro"

commit c125ae262f13c98ee07ac9779574259e80bfb4a7
Author: Dan Smith <[email protected]>
Date:   Wed Feb 9 11:43:32 2022 -0500

    latest from coda-oss

commit a0d7cb5355136cfce72749e97204cb1f33831ecc
Merge: 77c8052c0 ab0e65226
Author: Dan Smith <[email protected]>
Date:   Wed Feb 9 11:06:09 2022 -0500

    Merge branch 'master' into develop/update-externals

commit 77c8052c01c6d5b651b1e6f46548bd0b32440f13
Author: Dan Smith <[email protected]>
Date:   Fri Feb 4 10:25:58 2022 -0500

    our span now has iterators

commit de654b9e62833d8662adf24294f0171beb371a93
Author: Dan Smith <[email protected]>
Date:   Fri Feb 4 10:18:22 2022 -0500

    tweak GSL from coda-oss

commit e93b9e5bf73bb63b956bab762ad67b45b4da8c3c
Author: Dan Smith <[email protected]>
Date:   Fri Feb 4 09:37:52 2022 -0500

    latest from coda-oss

commit 409adfa5af8f45fbb7849c8ce28628a371aa745f
Merge: 76d0b20dc b0785b677
Author: Dan Smith <[email protected]>
Date:   Fri Feb 4 09:09:58 2022 -0500

    Merge branch 'master' into develop/update-externals

commit 76d0b20dc2fedcc29a86624b2c9f4d21a448dc0b
Author: Dan Smith <[email protected]>
Date:   Wed Feb 2 13:28:59 2022 -0500

    fix compiler warning from xml.lite

commit 9fde6d8d3322f63fb293b9a956107ceacb028396
Author: Dan Smith <[email protected]>
Date:   Wed Feb 2 13:05:19 2022 -0500

    not all unit-tests build in "externals"

commit a75381dfe838dbe758be1ba1c67bd924944a2f50
Author: Dan Smith <[email protected]>
Date:   Wed Feb 2 13:01:04 2022 -0500

    Update StringStream.h

commit 155632054b2d369ea2c1473784750efe29139e55
Author: Dan Smith <[email protected]>
Date:   Wed Feb 2 12:46:44 2022 -0500

    latest from NITRO

commit 2da0bfca6e3f45777ba9041dd1bfc2551ee22cc4
Author: Dan Smith <[email protected]>
Date:   Wed Feb 2 12:44:35 2022 -0500

    latest from coda-oss

commit 091a4632c2e83cca285bac315a2b17070b8dcfae
Merge: 5de601b67 59640e1ba
Author: Dan Smith <[email protected]>
Date:   Wed Feb 2 12:42:52 2022 -0500

    Merge branch 'master' into develop/update-externals

commit 5de601b676356a5ac474b71dc24bb7c0f74dfe71
Author: Dan Smith <[email protected]>
Date:   Tue Jan 25 15:32:11 2022 -0500

    latest from "nitro"

commit adf928ad07d0fd696b62a2dae1e49cc9ac014ade
Author: Dan Smith <[email protected]>
Date:   Tue Jan 25 15:30:35 2022 -0500

    latest from coda-oss

commit aee5e44e6b08be6c539bcfef629a2534fd60ad8a
Author: Dan Smith <[email protected]>
Date:   Tue Jan 25 10:57:47 2022 -0500

    std::filesystem instead of coda_oss::filesystem

commit ec9d17ac55ca7c70e315200951930e0bd66307a7
Merge: 833c031f4 cd06266e4
Author: Dan Smith <[email protected]>
Date:   Tue Jan 25 10:55:43 2022 -0500

    Merge branch 'master' into develop/update-externals

commit 833c031f411d0ae6de11b14c2d9affcc3efad5fb
Author: Dan Smith <[email protected]>
Date:   Thu Jan 20 12:58:04 2022 -0500

    latest from coda-oss

commit 2364ace449ee910356a98dde7f74a15c63aae761
Merge: 25b34ab78 8b6bcf777
Author: Dan Smith <[email protected]>
Date:   Tue Jan 18 13:28:04 2022 -0500

    Merge branch 'master' into develop/update-externals

commit 25b34ab784e78f98fa6aa4b0e9b04a53caf36779
Author: Dan Smith <[email protected]>
Date:   Tue Jan 18 12:33:44 2022 -0500

    minimize changes from "master"

commit 0b4deaa12fade653e20ccb4460fc424bef89d4c6
Author: Dan Smith <[email protected]>
Date:   Tue Jan 18 10:23:38 2022 -0500

    turn off some code-analysis diagnostics

commit 8797cd0b51617057496d9f89ea2a7602cabb13be
Author: Dan Smith <[email protected]>
Date:   Tue Jan 18 10:23:22 2022 -0500

    account for str:: changes in coda-oss

commit 920d0b79f1b91a1196171deaa61a91626ad7c44d
Author: Dan Smith <[email protected]>
Date:   Tue Jan 18 09:54:08 2022 -0500

    latest from coda-oss

commit 8e308afcf7b35945bdb3cb6c27cc94e63aa18b3b
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 15:26:32 2022 -0500

    construct a std::span directly, no make_span() utility (generates CA diagnostic)

commit d81a4d1aaac1cdaec1d9dc6a3838343e201d2b81
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 14:06:58 2022 -0500

    latest from coda-oss

commit 06716b781a3e6f0cf440b0f1bc5251bec415287e
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 13:24:46 2022 -0500

    finish renaming of sys/Filesystem.* to sys/filesystem.*

commit b3d0b4b8f4ad15c64e9f000143e64da3df1b241e
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 13:24:07 2022 -0500

    rename sys/Filesystem

commit c30ae278f01cc681c83a3a32afa3f3db174cfa06
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 12:30:21 2022 -0500

    no more gsl::make_span

commit e61dca0022fc39fdb9f4b63353dc93476fdd98bb
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 11:19:07 2022 -0500

    sys/Bit.h -> std/bit

commit bb67d052044cd1274d21b9b870f85da4b2040cf1
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 10:49:02 2022 -0500

    sys::Filesystem -> coda_oss::filesystem

commit ef212eaf09f87ffec27e8c043217ffbd33b29d1f
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 10:02:46 2022 -0500

    tweaks to get coda-oss building w/o warnings

commit 6f6bfaacc537067b7d36a363297e716e14e2e075
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 09:57:35 2022 -0500

    latest from "nitro"

commit 90be0243a2d384bc6ee0d81967240ee1d802bdb4
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 09:54:33 2022 -0500

    update to account for coda-oss changes

commit 28632726cc356524c5a3db5117ead37731342824
Author: Dan Smith <[email protected]>
Date:   Mon Jan 17 09:40:48 2022 -0500

    latest drop from coda-oss

commit 92632ef45f7369c3b0ebfdab65f4cdfa3f79f9d1
Author: Dan Smith <[email protected]>
Date:   Tue Jan 11 09:59:47 2022 -0500

    Utf-8 -> Windows-1252

commit 9b719935e8189bc3fbe57e4af4d221c3c49548c5
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 17:20:25 2022 -0500

    UTF-8 to native string conversion

commit 38dbe6d88e800f360cc9ae388558b09e5b65d95a
Merge: 74df9ee57 a11980f60
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 17:19:11 2022 -0500

    Merge branch 'master' into develop/update-externals

commit 74df9ee570e4d62fb6c435b4b5e0cef84b57b9d9
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 13:48:13 2022 -0500

    noexcept(false)

commit b5181bc210c3c2b0abc918842f6bd83b2a2d3907
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 12:01:40 2022 -0500

    remove comments with a backslash at the end

commit 08f8f9c27f46e793d3bc3d9e65b38facc8293521
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 11:36:15 2022 -0500

    certain NITRO unittests don't work in externals/nitro

commit dfc3ded9d3c52df1d038833afbdda94cf93e44ee
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 10:55:01 2022 -0500

    descriptor updates from "nitro"

commit c989c7ec700533a7ce0c294c09a80d68ed0ad6a4
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 10:41:48 2022 -0500

    fix #ifdef

commit 571ab4869aeb70f35dcfa046a36aed875c822739
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 10:27:53 2022 -0500

    latest from "nitro"

commit 26ba1a99646ac6db8b38d09e183be4318597efdd
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 10:26:37 2022 -0500

    latest from coda-oss

commit 28ab3500dc4c0f46ad61fd6356fdc76db8b4380e
Merge: 2cd678b7e 28afa6552
Author: Dan Smith <[email protected]>
Date:   Mon Jan 10 10:25:33 2022 -0500

    Merge branch 'master' into develop/update-externals

commit 2cd678b7e2d9fdd46906a6637903fd1325481ffc
Author: Dan Smith <[email protected]>
Date:   Thu Jan 6 15:39:49 2022 -0500

    more tweaks to remove compiler warnings

commit 5d8907616e5bdbf011a9ded45a7cf20e525789d8
Author: Dan Smith <[email protected]>
Date:   Thu Jan 6 15:19:57 2022 -0500

    remove errors/warnings from coda-oss

commit a535245afdd72ba24ad89f270d3012e12fd30c14
Author: Dan Smith <[email protected]>
Date:   Wed Jan 5 14:07:27 2022 -0500

    latest from nitro

commit aff92f496d1f402929707a3cb949c5fb7f4e14ba
Author: Dan Smith <[email protected]>
Date:   Wed Jan 5 14:04:39 2022 -0500

    latest from coda-oss

commit 41ba677e3418cb35ec636745ecb2a78fb7e1ac4e
Merge: 21cc8ed1f e2e3defbb
Author: Dan Smith <[email protected]>
Date:   Wed Jan 5 14:03:26 2022 -0500

    Merge branch 'master' into develop/update-externals

commit 21cc8ed1f01d74ab9d814fae97aa4f70c1e9ce34
Author: Dan Smith <[email protected]>
Date:   Mon Jan 3 16:43:08 2022 -0500

    use strongly-type TRE fields

commit 79eb6c8df45ee9f9d296c3d2152971458b6d8def
Author: Dan Smith <[email protected]>
Date:   Mon Jan 3 16:41:54 2022 -0500

    str::strip from coda-oss

commit faf20c7fbb3e3c1888215014b29a08c0b57f1caf
Author: Dan Smith <[email protected]>
Date:   Mon Jan 3 12:15:31 2022 -0500

    explicitly =delete move

commit ec79f1c0aac15ee0b36ed865b341f5d65e8ae0dd
Author: Dan Smith <[email protected]>
Date:   Mon Jan 3 11:12:43 2022 -0500

    latest from coda-oss

commit 22df5a95a3cbc3128780c63114a90181b4af33f8
Merge: db052a2d7 f1f19bdb6
Author: Dan Smith <[email protected]>
Date:   Wed Dec 29 12:25:28 2021 -0500

    Merge branch 'master' into develop/update-externals

commit db052a2d7bc7db05a9ccadcc5e1554275334bd9c
Author: Dan Smith <[email protected]>
Date:   Wed Dec 29 09:17:08 2021 -0500

    adjust for coda-oss changes

commit 74ce242cf352a333684379cc9bd0278c0cf57571
Author: Dan Smith <[email protected]>
Date:   Wed Dec 29 09:01:34 2021 -0500

    latest from coda-oss

commit dc960f74d430442cd3359b8218ad9d9a144bd070
Author: Dan Smith <[email protected]>
Date:   Tue Dec 28 10:37:48 2021 -0500

    latest from coda-oss

commit c6a4bd5b900d83b3407f8793cc756f46965700f4
Author: Dan Smith <[email protected]>
Date:   Fri Dec 17 09:14:23 2021 -0500

    sanity-check a URI

commit 82b1f21388dbf0f1b3e402ffaf151421d11149b8
Author: Dan Smith <[email protected]>
Date:   Wed Dec 15 09:38:14 2021 -0500

    create a "path" after splitting on ":"

commit 01cf2b5cadc18b97ac3a51bde9786b519755b1b1
Author: Dan Smith <[email protected]>
Date:   Wed Dec 15 08:50:17 2021 -0500

    simple URI validation

commit 3610f8e6e0f11a643831280819efb0aff3bb373d
Author: Dan Smith <[email protected]>
Date:   Tue Dec 14 09:46:21 2021 -0500

    xml.lite tweaks from coda-oss

commit 813be14c563d9f4829d342ec008b86da5ef77b27
Merge: 873d4b9d6 9ed21bed3
Author: Dan Smith <[email protected]>
Date:   Mon Dec 13 17:25:22 2021 -0500

    Merge branch 'master' into develop/update-externals

commit 873d4b9d6c55ae2736fc6208ece14aecf67adf10
Merge: 1c1a7222c ef191da2f
Author: Dan Smith <[email protected]>
Date:   Mon Dec 13 13:59:08 2021 -0500

    Merge branch 'master' into develop/update-externals

commit 1c1a7222c527f5ae89b9c960eb9c3fa9f2ccefa4
Author: Dan Smith <[email protected]>
Date:   Mon Dec 13 13:01:14 2021 -0500

    Squashed commit of the following:

    commit 474b7f2dc37eaa3144b97be8f785911ace32eb4d
    Author: Dan Smith <[email protected]>
    Date:   Mon Dec 13 13:00:02 2021 -0500

        xml.lite changes that need to get back to coda-oss

    commit c9c0ec36cff6ab97ca5c03c3db712794fb511e6e
    Author: Dan Smith <[email protected]>
    Date:   Mon Dec 13 11:45:39 2021 -0500

        Squashed commit of the following:

        commit 33bd17059640d2a02f9766285f05dcdff5de50a8
        Author: Dan Smith <[email protected]>
        Date:   Mon Dec 13 11:44:54 2021 -0500

            nitro release 2.10.7

        commit ef19ad2033851682eb3a37bada3a57fcb2b93ef8
        Author: Dan Smith <[email protected]>
        Date:   Mon Dec 13 11:42:09 2021 -0500

            coda-oss release 2021-12-13

        commit 86c1856021a5a944c464f9d3cba397a918f68a81
        Author: Dan Smith <[email protected]>
        Date:   Fri Dec 10 11:57:26 2021 -0500

            xml.lite tweaks from coda-oss

        commit f21f79d3f494e1ca8a5236e95ff5503fdb04e43b
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 17:36:09 2021 -0500

            test_xmlParser might be be running in coda-oss

        commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 16:09:17 2021 -0500

            "private" is part of name mangling

        commit 351a45f61d63e26fbd379516f073876bf5558050
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 15:54:13 2021 -0500

            more xml.lite updates from coda-oss

        commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 15:15:34 2021 -0500

            trying to fine the right macro for SWIG

        commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 14:51:34 2021 -0500

            need updates to Python bindings too

        commit e208dd4d072fd9f18860e84f54d68efdebef49a9
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 14:41:12 2021 -0500

            xml.lite changes from coda-oss

        commit 169df75cb962580fa63f1be3fbf9189c1fd74915
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 14:32:37 2021 -0500

            latest from coda-oss

    commit 1a74d4046085b286d6b0ae02bc62df608fc70ffa
    Author: Dan Smith <[email protected]>
    Date:   Fri Dec 10 12:26:10 2021 -0500

        more use of new xml.lite infrastructure

    commit 5d641a46f254f78f1e8a03c11f35f2f73c54ed5a
    Author: Dan Smith <[email protected]>
    Date:   Fri Dec 10 11:58:22 2021 -0500

        use new xml.lite APIs to simplify code

    commit 01f811e622eb3b8fcb7f20d8cba8c2d384894b31
    Author: Dan Smith <[email protected]>
    Date:   Fri Dec 10 11:57:57 2021 -0500

        Squashed commit of the following:

        commit 86c1856021a5a944c464f9d3cba397a918f68a81
        Author: Dan Smith <[email protected]>
        Date:   Fri Dec 10 11:57:26 2021 -0500

            xml.lite tweaks from coda-oss

        commit f21f79d3f494e1ca8a5236e95ff5503fdb04e43b
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 17:36:09 2021 -0500

            test_xmlParser might be be running in coda-oss

        commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 16:09:17 2021 -0500

            "private" is part of name mangling

        commit 351a45f61d63e26fbd379516f073876bf5558050
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 15:54:13 2021 -0500

            more xml.lite updates from coda-oss

        commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 15:15:34 2021 -0500

            trying to fine the right macro for SWIG

        commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 14:51:34 2021 -0500

            need updates to Python bindings too

        commit e208dd4d072fd9f18860e84f54d68efdebef49a9
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 14:41:12 2021 -0500

            xml.lite changes from coda-oss

        commit 169df75cb962580fa63f1be3fbf9189c1fd74915
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 14:32:37 2021 -0500

            latest from coda-oss

    commit 25b83eb24e0ebf095522df47349e7c5fbf1df8e3
    Author: Dan Smith <[email protected]>
    Date:   Fri Dec 10 09:06:38 2021 -0500

        Squashed commit of the following:

        commit 3f59a6260e33423c21326dde8e5bed7dc93cd9f0
        Author: Dan Smith <[email protected]>
        Date:   Fri Dec 10 08:44:54 2021 -0500

            still can't get French XML working

        commit 1a826e5c300d0e2781a015d1916eba8556a36c2d
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 17:37:11 2021 -0500

            Squashed commit of the following:

            commit f21f79d3f494e1ca8a5236e95ff5503fdb04e43b
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 17:36:09 2021 -0500

                test_xmlParser might be be running in coda-oss

            commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 16:09:17 2021 -0500

                "private" is part of name mangling

            commit 351a45f61d63e26fbd379516f073876bf5558050
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:54:13 2021 -0500

                more xml.lite updates from coda-oss

            commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:15:34 2021 -0500

                trying to fine the right macro for SWIG

            commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:51:34 2021 -0500

                need updates to Python bindings too

            commit e208dd4d072fd9f18860e84f54d68efdebef49a9
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:41:12 2021 -0500

                xml.lite changes from coda-oss

            commit 169df75cb962580fa63f1be3fbf9189c1fd74915
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 14:32:37 2021 -0500

                latest from coda-oss

        commit f705be9129ea7c71d6bdc25899b53fd3f655b974
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 17:35:35 2021 -0500

            add overloads for other code

        commit d61323431bea6e33c4f91b60cb83f3401b76671d
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 16:57:55 2021 -0500

            option to disable XML validation for SICD too

        commit bc2c97e9f79ce91f2dc0ce9b3d5e45a7e60a852b
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 16:09:44 2021 -0500

            Squashed commit of the following:

            commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 16:09:17 2021 -0500

                "private" is part of name mangling

            commit 351a45f61d63e26fbd379516f073876bf5558050
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:54:13 2021 -0500

                more xml.lite updates from coda-oss

            commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:15:34 2021 -0500

                trying to fine the right macro for SWIG

            commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:51:34 2021 -0500

                need updates to Python bindings too

            commit e208dd4d072fd9f18860e84f54d68efdebef49a9
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:41:12 2021 -0500

                xml.lite changes from coda-oss

            commit 169df75cb962580fa63f1be3fbf9189c1fd74915
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 14:32:37 2021 -0500

                latest from coda-oss

        commit 4cd813b2f115cd2446821bf01dcf7d8c27781322
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 15:16:01 2021 -0500

            Squashed commit of the following:

            commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:15:34 2021 -0500

                trying to fine the right macro for SWIG

            commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:51:34 2021 -0500

                need updates to Python bindings too

            commit e208dd4d072fd9f18860e84f54d68efdebef49a9
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:41:12 2021 -0500

                xml.lite changes from coda-oss

            commit 169df75cb962580fa63f1be3fbf9189c1fd74915
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 14:32:37 2021 -0500

                latest from coda-oss

        commit 7b210f96d175c35dd4d93a8ede3b1127b6fe442c
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 14:51:53 2021 -0500

            Squashed commit of the following:

            commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:51:34 2021 -0500

                need updates to Python bindings too

            commit e208dd4d072fd9f18860e84f54d68efdebef49a9
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:41:12 2021 -0500

                xml.lite changes from coda-oss

            commit 169df75cb962580fa63f1be3fbf9189c1fd74915
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 14:32:37 2021 -0500

                latest from coda-oss

        commit 4a4d621a17bb568fa07453a6a06f08f34efb7b73
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 14:47:21 2021 -0500

            trying to get the "french" SICD unit-test working

        commit d63e6eace772c8d02616f467d698da48a14568dd
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 14:42:55 2021 -0500

            Squashed commit of the following:

            commit e208dd4d072fd9f18860e84f54d68efdebef49a9
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:41:12 2021 -0500

                xml.lite changes from coda-oss

            commit 169df75cb962580fa63f1be3fbf9189c1fd74915
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 14:32:37 2021 -0500

                latest from coda-oss

        commit d1a7e6f442aff2530a7fd8078b88a56ce050238f
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 09:29:07 2021 -0500

            test_valid_six unittests now working

        commit d6fb257c92ab8e97e2d2a2164484011c60d2c95d
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 17:45:26 2021 -0500

            trying to re-enable more unittests

        commit c787e98a7f339740389e10f5c5cb3760617f3ed1
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 16:54:28 2021 -0500

            unit-test breaks on Linux

        commit bd82787be8ae4f4cd463faa2bb6d2cb5c6d7dba6
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 15:25:31 2021 -0500

            Squashed commit of the following:

            commit c56ac71fcb152d3a802a548b59d90ccc09dfaf83
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 15:23:00 2021 -0500

                merge in develop/SIDD-3.0

        commit e621466a38f21d5b66847f5358b4def1fd4ea4ce
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 15:08:04 2021 -0500

            merge in develop/8AMPI_PHSI

    commit 67768ea901bbd983becc4790b478afe0f17828d5
    Author: Dan Smith <[email protected]>
    Date:   Thu Dec 9 10:02:19 2021 -0500

        Squashed commit of the following:

        commit d1a7e6f442aff2530a7fd8078b88a56ce050238f
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 09:29:07 2021 -0500

            test_valid_six unittests now working

        commit d6fb257c92ab8e97e2d2a2164484011c60d2c95d
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 17:45:26 2021 -0500

            trying to re-enable more unittests

        commit c787e98a7f339740389e10f5c5cb3760617f3ed1
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 16:54:28 2021 -0500

            unit-test breaks on Linux

        commit bd82787be8ae4f4cd463faa2bb6d2cb5c6d7dba6
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 15:25:31 2021 -0500

            Squashed commit of the following:

            commit c56ac71fcb152d3a802a548b59d90ccc09dfaf83
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 15:23:00 2021 -0500

                merge in develop/SIDD-3.0

        commit e621466a38f21d5b66847f5358b4def1fd4ea4ce
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 15:08:04 2021 -0500

            merge in develop/8AMPI_PHSI

    commit b582c055ba1f0f2532d2f5ad4c97b3cd649e69bd
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 8 15:26:24 2021 -0500

        Squashed commit of the following:

        commit bd82787be8ae4f4cd463faa2bb6d2cb5c6d7dba6
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 15:25:31 2021 -0500

            Squashed commit of the following:

            commit c56ac71fcb152d3a802a548b59d90ccc09dfaf83
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 15:23:00 2021 -0500

                merge in develop/SIDD-3.0

        commit e621466a38f21d5b66847f5358b4def1fd4ea4ce
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 15:08:04 2021 -0500

            merge in develop/8AMPI_PHSI

    commit c56ac71fcb152d3a802a548b59d90ccc09dfaf83
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 8 15:23:00 2021 -0500

        merge in develop/SIDD-3.0

commit 33bd17059640d2a02f9766285f05dcdff5de50a8
Author: Dan Smith <[email protected]>
Date:   Mon Dec 13 11:44:54 2021 -0500

    nitro release 2.10.7

commit ef19ad2033851682eb3a37bada3a57fcb2b93ef8
Author: Dan Smith <[email protected]>
Date:   Mon Dec 13 11:42:09 2021 -0500

    coda-oss release 2021-12-13

commit 86c1856021a5a944c464f9d3cba397a918f68a81
Author: Dan Smith <[email protected]>
Date:   Fri Dec 10 11:57:26 2021 -0500

    xml.lite tweaks from coda-oss

commit f21f79d3f494e1ca8a5236e95ff5503fdb04e43b
Author: Dan Smith <[email protected]>
Date:   Thu Dec 9 17:36:09 2021 -0500

    test_xmlParser might be be running in coda-oss

commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
Author: Dan Smith <[email protected]>
Date:   Thu Dec 9 16:09:17 2021 -0500

    "private" is part of name mangling

commit 351a45f61d63e26fbd379516f073876bf5558050
Author: Dan Smith <[email protected]>
Date:   Thu Dec 9 15:54:13 2021 -0500

    more xml.lite updates from coda-oss

commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
Author: Dan Smith <[email protected]>
Date:   Thu Dec 9 15:15:34 2021 -0500

    trying to fine the right macro for SWIG

commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
Author: Dan Smith <[email protected]>
Date:   Thu Dec 9 14:51:34 2021 -0500

    need updates to Python bindings too

commit e208dd4d072fd9f18860e84f54d68efdebef49a9
Author: Dan Smith <[email protected]>
Date:   Thu Dec 9 14:41:12 2021 -0500

    xml.lite changes from coda-oss

commit 169df75cb962580fa63f1be3fbf9189c1fd74915
Author: Dan Smith <[email protected]>
Date:   Wed Dec 8 14:32:37 2021 -0500

    latest from coda-oss

* Squashed commit of the following:

commit f5b9dda0cca9b853367f070e529353ea29797c81
Author: Dan Smith <[email protected]>
Date:   Mon Apr 18 14:01:14 2022 -0400

    six::Init::undefined<std::string> initialized std::string to "" which is already done by default

commit 03a8bd7ff7a0945c5779cf2eef13b0a2ea970c40
Author: Dan Smith <[email protected]>
Date:   Mon Apr 18 13:16:28 2022 -0400

    Squashed commit of the following:

    commit e706d7eef95059373d6d95adb0240baf202d4762
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 13:16:01 2022 -0400

        some NITRO unit-tests don't work in "externals"

    commit 05fc1f8d2b499d58e79a3fc4dc7961f88fb290bf
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:35:39 2022 -0400

        account for change to nitf::MemorySource

    commit 01d65e595015b143007ad1c414d68bed41b0eb65
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:25:00 2022 -0400

        Update ReleaseNotes.md

    commit 5296635b2c7a02d9b632568ff8f274df69c0239d
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:17:55 2022 -0400

        latest from "nitro"

    commit 543bf38718e98f81b9a43d3299941243ab59f7a5
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:16:02 2022 -0400

        latest from coda-oss

    commit f8fb45a1ef2b0c766a8fff532fc35ce48bae2be3
    Merge: 043d37c66 844a356ba
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:09:02 2022 -0400

        Merge branch 'master' into develop/update-externals

    commit 043d37c664378bd523c86e23d81f594d7f165b62
    Author: Dan Smith <[email protected]>
    Date:   Thu Feb 24 08:26:22 2022 -0500

        unit tests that don't work in "externals"

    commit 2df69b20f74ac2b56e4e07c5e74a7c226230faf3
    Author: J. Daniel Smith <[email protected]>
    Date:   Wed Feb 23 21:30:32 2022 -0500

        imageCompression() now returns an "enum"

    commit b378acef90d1bcee7b3844ec830b5a10f68ff9a6
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 23 17:28:50 2022 -0500

        latest from "nitro"

    commit cc10dba53875a84f58f43321279fe67d3b12735c
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 23 17:23:35 2022 -0500

        latest from coda-oss

    commit c08a0cebb45496c10efc929e65f646f8ba3c182d
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 23 13:45:48 2022 -0500

        latest from coda-oss

    commit 4ee8337e5b0840065ba35fe85c3ee929593a1ece
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 9 11:44:59 2022 -0500

        latest from "nitro"

    commit c125ae262f13c98ee07ac9779574259e80bfb4a7
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 9 11:43:32 2022 -0500

        latest from coda-oss

    commit a0d7cb5355136cfce72749e97204cb1f33831ecc
    Merge: 77c8052c0 ab0e65226
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 9 11:06:09 2022 -0500

        Merge branch 'master' into develop/update-externals

    commit 77c8052c01c6d5b651b1e6f46548bd0b32440f13
    Author: Dan Smith <[email protected]>
    Date:   Fri Feb 4 10:25:58 2022 -0500

        our span now has iterators

    commit de654b9e62833d8662adf24294f0171beb371a93
    Author: Dan Smith <[email protected]>
    Date:   Fri Feb 4 10:18:22 2022 -0500

        tweak GSL from coda-oss

    commit e93b9e5bf73bb63b956bab762ad67b45b4da8c3c
    Author: Dan Smith <[email protected]>
    Date:   Fri Feb 4 09:37:52 2022 -0500

        latest from coda-oss

    commit 409adfa5af8f45fbb7849c8ce28628a371aa745f
    Merge: 76d0b20dc b0785b677
    Author: Dan Smith <[email protected]>
    Date:   Fri Feb 4 09:09:58 2022 -0500

        Merge branch 'master' into develop/update-externals

    commit 76d0b20dc2fedcc29a86624b2c9f4d21a448dc0b
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 2 13:28:59 2022 -0500

        fix compiler warning from xml.lite

    commit 9fde6d8d3322f63fb293b9a956107ceacb028396
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 2 13:05:19 2022 -0500

        not all unit-tests build in "externals"

    commit a75381dfe838dbe758be1ba1c67bd924944a2f50
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 2 13:01:04 2022 -0500

        Update StringStream.h

    commit 155632054b2d369ea2c1473784750efe29139e55
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 2 12:46:44 2022 -0500

        latest from NITRO

    commit 2da0bfca6e3f45777ba9041dd1bfc2551ee22cc4
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 2 12:44:35 2022 -0500

        latest from coda-oss

    commit 091a4632c2e83cca285bac315a2b17070b8dcfae
    Merge: 5de601b67 59640e1ba
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 2 12:42:52 2022 -0500

        Merge branch 'master' into develop/update-externals

    commit 5de601b676356a5ac474b71dc24bb7c0f74dfe71
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 25 15:32:11 2022 -0500

        latest from "nitro"

    commit adf928ad07d0fd696b62a2dae1e49cc9ac014ade
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 25 15:30:35 2022 -0500

        latest from coda-oss

    commit aee5e44e6b08be6c539bcfef629a2534fd60ad8a
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 25 10:57:47 2022 -0500

        std::filesystem instead of coda_oss::filesystem

    commit ec9d17ac55ca7c70e315200951930e0bd66307a7
    Merge: 833c031f4 cd06266e4
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 25 10:55:43 2022 -0500

        Merge branch 'master' into develop/update-externals

    commit 833c031f411d0ae6de11b14c2d9affcc3efad5fb
    Author: Dan Smith <[email protected]>
    Date:   Thu Jan 20 12:58:04 2022 -0500

        latest from coda-oss

    commit 2364ace449ee910356a98dde7f74a15c63aae761
    Merge: 25b34ab78 8b6bcf777
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 18 13:28:04 2022 -0500

        Merge branch 'master' into develop/update-externals

    commit 25b34ab784e78f98fa6aa4b0e9b04a53caf36779
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 18 12:33:44 2022 -0500

        minimize changes from "master"

    commit 0b4deaa12fade653e20ccb4460fc424bef89d4c6
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 18 10:23:38 2022 -0500

        turn off some code-analysis diagnostics

    commit 8797cd0b51617057496d9f89ea2a7602cabb13be
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 18 10:23:22 2022 -0500

        account for str:: changes in coda-oss

    commit 920d0b79f1b91a1196171deaa61a91626ad7c44d
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 18 09:54:08 2022 -0500

        latest from coda-oss

    commit 8e308afcf7b35945bdb3cb6c27cc94e63aa18b3b
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 15:26:32 2022 -0500

        construct a std::span directly, no make_span() utility (generates CA diagnostic)

    commit d81a4d1aaac1cdaec1d9dc6a3838343e201d2b81
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 14:06:58 2022 -0500

        latest from coda-oss

    commit 06716b781a3e6f0cf440b0f1bc5251bec415287e
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 13:24:46 2022 -0500

        finish renaming of sys/Filesystem.* to sys/filesystem.*

    commit b3d0b4b8f4ad15c64e9f000143e64da3df1b241e
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 13:24:07 2022 -0500

        rename sys/Filesystem

    commit c30ae278f01cc681c83a3a32afa3f3db174cfa06
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 12:30:21 2022 -0500

        no more gsl::make_span

    commit e61dca0022fc39fdb9f4b63353dc93476fdd98bb
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 11:19:07 2022 -0500

        sys/Bit.h -> std/bit

    commit bb67d052044cd1274d21b9b870f85da4b2040cf1
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 10:49:02 2022 -0500

        sys::Filesystem -> coda_oss::filesystem

    commit ef212eaf09f87ffec27e8c043217ffbd33b29d1f
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 10:02:46 2022 -0500

        tweaks to get coda-oss building w/o warnings

    commit 6f6bfaacc537067b7d36a363297e716e14e2e075
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 09:57:35 2022 -0500

        latest from "nitro"

    commit 90be0243a2d384bc6ee0d81967240ee1d802bdb4
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 09:54:33 2022 -0500

        update to account for coda-oss changes

    commit 28632726cc356524c5a3db5117ead37731342824
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 17 09:40:48 2022 -0500

        latest drop from coda-oss

    commit 92632ef45f7369c3b0ebfdab65f4cdfa3f79f9d1
    Author: Dan Smith <[email protected]>
    Date:   Tue Jan 11 09:59:47 2022 -0500

        Utf-8 -> Windows-1252

    commit 9b719935e8189bc3fbe57e4af4d221c3c49548c5
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 17:20:25 2022 -0500

        UTF-8 to native string conversion

    commit 38dbe6d88e800f360cc9ae388558b09e5b65d95a
    Merge: 74df9ee57 a11980f60
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 17:19:11 2022 -0500

        Merge branch 'master' into develop/update-externals

    commit 74df9ee570e4d62fb6c435b4b5e0cef84b57b9d9
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 13:48:13 2022 -0500

        noexcept(false)

    commit b5181bc210c3c2b0abc918842f6bd83b2a2d3907
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 12:01:40 2022 -0500

        remove comments with a backslash at the end

    commit 08f8f9c27f46e793d3bc3d9e65b38facc8293521
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 11:36:15 2022 -0500

        certain NITRO unittests don't work in externals/nitro

    commit dfc3ded9d3c52df1d038833afbdda94cf93e44ee
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 10:55:01 2022 -0500

        descriptor updates from "nitro"

    commit c989c7ec700533a7ce0c294c09a80d68ed0ad6a4
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 10:41:48 2022 -0500

        fix #ifdef

    commit 571ab4869aeb70f35dcfa046a36aed875c822739
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 10:27:53 2022 -0500

        latest from "nitro"

    commit 26ba1a99646ac6db8b38d09e183be4318597efdd
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 10:26:37 2022 -0500

        latest from coda-oss

    commit 28ab3500dc4c0f46ad61fd6356fdc76db8b4380e
    Merge: 2cd678b7e 28afa6552
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 10 10:25:33 2022 -0500

        Merge branch 'master' into develop/update-externals

    commit 2cd678b7e2d9fdd46906a6637903fd1325481ffc
    Author: Dan Smith <[email protected]>
    Date:   Thu Jan 6 15:39:49 2022 -0500

        more tweaks to remove compiler warnings

    commit 5d8907616e5bdbf011a9ded45a7cf20e525789d8
    Author: Dan Smith <[email protected]>
    Date:   Thu Jan 6 15:19:57 2022 -0500

        remove errors/warnings from coda-oss

    commit a535245afdd72ba24ad89f270d3012e12fd30c14
    Author: Dan Smith <[email protected]>
    Date:   Wed Jan 5 14:07:27 2022 -0500

        latest from nitro

    commit aff92f496d1f402929707a3cb949c5fb7f4e14ba
    Author: Dan Smith <[email protected]>
    Date:   Wed Jan 5 14:04:39 2022 -0500

        latest from coda-oss

    commit 41ba677e3418cb35ec636745ecb2a78fb7e1ac4e
    Merge: 21cc8ed1f e2e3defbb
    Author: Dan Smith <[email protected]>
    Date:   Wed Jan 5 14:03:26 2022 -0500

        Merge branch 'master' into develop/update-externals

    commit 21cc8ed1f01d74ab9d814fae97aa4f70c1e9ce34
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 3 16:43:08 2022 -0500

        use strongly-type TRE fields

    commit 79eb6c8df45ee9f9d296c3d2152971458b6d8def
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 3 16:41:54 2022 -0500

        str::strip from coda-oss

    commit faf20c7fbb3e3c1888215014b29a08c0b57f1caf
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 3 12:15:31 2022 -0500

        explicitly =delete move

    commit ec79f1c0aac15ee0b36ed865b341f5d65e8ae0dd
    Author: Dan Smith <[email protected]>
    Date:   Mon Jan 3 11:12:43 2022 -0500

        latest from coda-oss

    commit 22df5a95a3cbc3128780c63114a90181b4af33f8
    Merge: db052a2d7 f1f19bdb6
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 29 12:25:28 2021 -0500

        Merge branch 'master' into develop/update-externals

    commit db052a2d7bc7db05a9ccadcc5e1554275334bd9c
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 29 09:17:08 2021 -0500

        adjust for coda-oss changes

    commit 74ce242cf352a333684379cc9bd0278c0cf57571
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 29 09:01:34 2021 -0500

        latest from coda-oss

    commit dc960f74d430442cd3359b8218ad9d9a144bd070
    Author: Dan Smith <[email protected]>
    Date:   Tue Dec 28 10:37:48 2021 -0500

        latest from coda-oss

    commit c6a4bd5b900d83b3407f8793cc756f46965700f4
    Author: Dan Smith <[email protected]>
    Date:   Fri Dec 17 09:14:23 2021 -0500

        sanity-check a URI

    commit 82b1f21388dbf0f1b3e402ffaf151421d11149b8
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 15 09:38:14 2021 -0500

        create a "path" after splitting on ":"

    commit 01cf2b5cadc18b97ac3a51bde9786b519755b1b1
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 15 08:50:17 2021 -0500

        simple URI validation

    commit 3610f8e6e0f11a643831280819efb0aff3bb373d
    Author: Dan Smith <[email protected]>
    Date:   Tue Dec 14 09:46:21 2021 -0500

        xml.lite tweaks from coda-oss

    commit 813be14c563d9f4829d342ec008b86da5ef77b27
    Merge: 873d4b9d6 9ed21bed3
    Author: Dan Smith <[email protected]>
    Date:   Mon Dec 13 17:25:22 2021 -0500

        Merge branch 'master' into develop/update-externals

    commit 873d4b9d6c55ae2736fc6208ece14aecf67adf10
    Merge: 1c1a7222c ef191da2f
    Author: Dan Smith <[email protected]>
    Date:   Mon Dec 13 13:59:08 2021 -0500

        Merge branch 'master' into develop/update-externals

    commit 1c1a7222c527f5ae89b9c960eb9c3fa9f2ccefa4
    Author: Dan Smith <[email protected]>
    Date:   Mon Dec 13 13:01:14 2021 -0500

        Squashed commit of the following:

        commit 474b7f2dc37eaa3144b97be8f785911ace32eb4d
        Author: Dan Smith <[email protected]>
        Date:   Mon Dec 13 13:00:02 2021 -0500

            xml.lite changes that need to get back to coda-oss

        commit c9c0ec36cff6ab97ca5c03c3db712794fb511e6e
        Author: Dan Smith <[email protected]>
        Date:   Mon Dec 13 11:45:39 2021 -0500

            Squashed commit of the following:

            commit 33bd17059640d2a02f9766285f05dcdff5de50a8
            Author: Dan Smith <[email protected]>
            Date:   Mon Dec 13 11:44:54 2021 -0500

                nitro release 2.10.7

            commit ef19ad2033851682eb3a37bada3a57fcb2b93ef8
            Author: Dan Smith <[email protected]>
            Date:   Mon Dec 13 11:42:09 2021 -0500

                coda-oss release 2021-12-13

            commit 86c1856021a5a944c464f9d3cba397a918f68a81
            Author: Dan Smith <[email protected]>
            Date:   Fri Dec 10 11:57:26 2021 -0500

                xml.lite tweaks from coda-oss

            commit f21f79d3f494e1ca8a5236e95ff5503fdb04e43b
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 17:36:09 2021 -0500

                test_xmlParser might be be running in coda-oss

            commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 16:09:17 2021 -0500

                "private" is part of name mangling

            commit 351a45f61d63e26fbd379516f073876bf5558050
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:54:13 2021 -0500

                more xml.lite updates from coda-oss

            commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:15:34 2021 -0500

                trying to fine the right macro for SWIG

            commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:51:34 2021 -0500

                need updates to Python bindings too

            commit e208dd4d072fd9f18860e84f54d68efdebef49a9
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:41:12 2021 -0500

                xml.lite changes from coda-oss

            commit 169df75cb962580fa63f1be3fbf9189c1fd74915
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 14:32:37 2021 -0500

                latest from coda-oss

        commit 1a74d4046085b286d6b0ae02bc62df608fc70ffa
        Author: Dan Smith <[email protected]>
        Date:   Fri Dec 10 12:26:10 2021 -0500

            more use of new xml.lite infrastructure

        commit 5d641a46f254f78f1e8a03c11f35f2f73c54ed5a
        Author: Dan Smith <[email protected]>
        Date:   Fri Dec 10 11:58:22 2021 -0500

            use new xml.lite APIs to simplify code

        commit 01f811e622eb3b8fcb7f20d8cba8c2d384894b31
        Author: Dan Smith <[email protected]>
        Date:   Fri Dec 10 11:57:57 2021 -0500

            Squashed commit of the following:

            commit 86c1856021a5a944c464f9d3cba397a918f68a81
            Author: Dan Smith <[email protected]>
            Date:   Fri Dec 10 11:57:26 2021 -0500

                xml.lite tweaks from coda-oss

            commit f21f79d3f494e1ca8a5236e95ff5503fdb04e43b
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 17:36:09 2021 -0500

                test_xmlParser might be be running in coda-oss

            commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 16:09:17 2021 -0500

                "private" is part of name mangling

            commit 351a45f61d63e26fbd379516f073876bf5558050
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:54:13 2021 -0500

                more xml.lite updates from coda-oss

            commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:15:34 2021 -0500

                trying to fine the right macro for SWIG

            commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:51:34 2021 -0500

                need updates to Python bindings too

            commit e208dd4d072fd9f18860e84f54d68efdebef49a9
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:41:12 2021 -0500

                xml.lite changes from coda-oss

            commit 169df75cb962580fa63f1be3fbf9189c1fd74915
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 14:32:37 2021 -0500

                latest from coda-oss

        commit 25b83eb24e0ebf095522df47349e7c5fbf1df8e3
        Author: Dan Smith <[email protected]>
        Date:   Fri Dec 10 09:06:38 2021 -0500

            Squashed commit of the following:

            commit 3f59a6260e33423c21326dde8e5bed7dc93cd9f0
            Author: Dan Smith <[email protected]>
            Date:   Fri Dec 10 08:44:54 2021 -0500

                still can't get French XML working

            commit 1a826e5c300d0e2781a015d1916eba8556a36c2d
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 17:37:11 2021 -0500

                Squashed commit of the following:

                commit f21f79d3f494e1ca8a5236e95ff5503fdb04e43b
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 17:36:09 2021 -0500

                    test_xmlParser might be be running in coda-oss

                commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 16:09:17 2021 -0500

                    "private" is part of name mangling

                commit 351a45f61d63e26fbd379516f073876bf5558050
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 15:54:13 2021 -0500

                    more xml.lite updates from coda-oss

                commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 15:15:34 2021 -0500

                    trying to fine the right macro for SWIG

                commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 14:51:34 2021 -0500

                    need updates to Python bindings too

                commit e208dd4d072fd9f18860e84f54d68efdebef49a9
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 14:41:12 2021 -0500

                    xml.lite changes from coda-oss

                commit 169df75cb962580fa63f1be3fbf9189c1fd74915
                Author: Dan Smith <[email protected]>
                Date:   Wed Dec 8 14:32:37 2021 -0500

                    latest from coda-oss

            commit f705be9129ea7c71d6bdc25899b53fd3f655b974
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 17:35:35 2021 -0500

                add overloads for other code

            commit d61323431bea6e33c4f91b60cb83f3401b76671d
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 16:57:55 2021 -0500

                option to disable XML validation for SICD too

            commit bc2c97e9f79ce91f2dc0ce9b3d5e45a7e60a852b
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 16:09:44 2021 -0500

                Squashed commit of the following:

                commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 16:09:17 2021 -0500

                    "private" is part of name mangling

                commit 351a45f61d63e26fbd379516f073876bf5558050
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 15:54:13 2021 -0500

                    more xml.lite updates from coda-oss

                commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 15:15:34 2021 -0500

                    trying to fine the right macro for SWIG

                commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 14:51:34 2021 -0500

                    need updates to Python bindings too

                commit e208dd4d072fd9f18860e84f54d68efdebef49a9
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 14:41:12 2021 -0500

                    xml.lite changes from coda-oss

                commit 169df75cb962580fa63f1be3fbf9189c1fd74915
                Author: Dan Smith <[email protected]>
                Date:   Wed Dec 8 14:32:37 2021 -0500

                    latest from coda-oss

            commit 4cd813b2f115cd2446821bf01dcf7d8c27781322
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 15:16:01 2021 -0500

                Squashed commit of the following:

                commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 15:15:34 2021 -0500

                    trying to fine the right macro for SWIG

                commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 14:51:34 2021 -0500

                    need updates to Python bindings too

                commit e208dd4d072fd9f18860e84f54d68efdebef49a9
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 14:41:12 2021 -0500

                    xml.lite changes from coda-oss

                commit 169df75cb962580fa63f1be3fbf9189c1fd74915
                Author: Dan Smith <[email protected]>
                Date:   Wed Dec 8 14:32:37 2021 -0500

                    latest from coda-oss

            commit 7b210f96d175c35dd4d93a8ede3b1127b6fe442c
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:51:53 2021 -0500

                Squashed commit of the following:

                commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 14:51:34 2021 -0500

                    need updates to Python bindings too

                commit e208dd4d072fd9f18860e84f54d68efdebef49a9
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 14:41:12 2021 -0500

                    xml.lite changes from coda-oss

                commit 169df75cb962580fa63f1be3fbf9189c1fd74915
                Author: Dan Smith <[email protected]>
                Date:   Wed Dec 8 14:32:37 2021 -0500

                    latest from coda-oss

            commit 4a4d621a17bb568fa07453a6a06f08f34efb7b73
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:47:21 2021 -0500

                trying to get the "french" SICD unit-test working

            commit d63e6eace772c8d02616f467d698da48a14568dd
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 14:42:55 2021 -0500

                Squashed commit of the following:

                commit e208dd4d072fd9f18860e84f54d68efdebef49a9
                Author: Dan Smith <[email protected]>
                Date:   Thu Dec 9 14:41:12 2021 -0500

                    xml.lite changes from coda-oss

                commit 169df75cb962580fa63f1be3fbf9189c1fd74915
                Author: Dan Smith <[email protected]>
                Date:   Wed Dec 8 14:32:37 2021 -0500

                    latest from coda-oss

            commit d1a7e6f442aff2530a7fd8078b88a56ce050238f
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 09:29:07 2021 -0500

                test_valid_six unittests now working

            commit d6fb257c92ab8e97e2d2a2164484011c60d2c95d
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 17:45:26 2021 -0500

                trying to re-enable more unittests

            commit c787e98a7f339740389e10f5c5cb3760617f3ed1
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 16:54:28 2021 -0500

                unit-test breaks on Linux

            commit bd82787be8ae4f4cd463faa2bb6d2cb5c6d7dba6
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 15:25:31 2021 -0500

                Squashed commit of the following:

                commit c56ac71fcb152d3a802a548b59d90ccc09dfaf83
                Author: Dan Smith <[email protected]>
                Date:   Wed Dec 8 15:23:00 2021 -0500

                    merge in develop/SIDD-3.0

            commit e621466a38f21d5b66847f5358b4def1fd4ea4ce
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 15:08:04 2021 -0500

                merge in develop/8AMPI_PHSI

        commit 67768ea901bbd983becc4790b478afe0f17828d5
        Author: Dan Smith <[email protected]>
        Date:   Thu Dec 9 10:02:19 2021 -0500

            Squashed commit of the following:

            commit d1a7e6f442aff2530a7fd8078b88a56ce050238f
            Author: Dan Smith <[email protected]>
            Date:   Thu Dec 9 09:29:07 2021 -0500

                test_valid_six unittests now working

            commit d6fb257c92ab8e97e2d2a2164484011c60d2c95d
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 17:45:26 2021 -0500

                trying to re-enable more unittests

            commit c787e98a7f339740389e10f5c5cb3760617f3ed1
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 16:54:28 2021 -0500

                unit-test breaks on Linux

            commit bd82787be8ae4f4cd463faa2bb6d2cb5c6d7dba6
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 15:25:31 2021 -0500

                Squashed commit of the following:

                commit c56ac71fcb152d3a802a548b59d90ccc09dfaf83
                Author: Dan Smith <[email protected]>
                Date:   Wed Dec 8 15:23:00 2021 -0500

                    merge in develop/SIDD-3.0

            commit e621466a38f21d5b66847f5358b4def1fd4ea4ce
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 15:08:04 2021 -0500

                merge in develop/8AMPI_PHSI

        commit b582c055ba1f0f2532d2f5ad4c97b3cd649e69bd
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 15:26:24 2021 -0500

            Squashed commit of the following:

            commit bd82787be8ae4f4cd463faa2bb6d2cb5c6d7dba6
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 15:25:31 2021 -0500

                Squashed commit of the following:

                commit c56ac71fcb152d3a802a548b59d90ccc09dfaf83
                Author: Dan Smith <[email protected]>
                Date:   Wed Dec 8 15:23:00 2021 -0500

                    merge in develop/SIDD-3.0

            commit e621466a38f21d5b66847f5358b4def1fd4ea4ce
            Author: Dan Smith <[email protected]>
            Date:   Wed Dec 8 15:08:04 2021 -0500

                merge in develop/8AMPI_PHSI

        commit c56ac71fcb152d3a802a548b59d90ccc09dfaf83
        Author: Dan Smith <[email protected]>
        Date:   Wed Dec 8 15:23:00 2021 -0500

            merge in develop/SIDD-3.0

    commit 33bd17059640d2a02f9766285f05dcdff5de50a8
    Author: Dan Smith <[email protected]>
    Date:   Mon Dec 13 11:44:54 2021 -0500

        nitro release 2.10.7

    commit ef19ad2033851682eb3a37bada3a57fcb2b93ef8
    Author: Dan Smith <[email protected]>
    Date:   Mon Dec 13 11:42:09 2021 -0500

        coda-oss release 2021-12-13

    commit 86c1856021a5a944c464f9d3cba397a918f68a81
    Author: Dan Smith <[email protected]>
    Date:   Fri Dec 10 11:57:26 2021 -0500

        xml.lite tweaks from coda-oss

    commit f21f79d3f494e1ca8a5236e95ff5503fdb04e43b
    Author: Dan Smith <[email protected]>
    Date:   Thu Dec 9 17:36:09 2021 -0500

        test_xmlParser might be be running in coda-oss

    commit 3526cd00c6c29b7e8578b204088cafe4ec773ee1
    Author: Dan Smith <[email protected]>
    Date:   Thu Dec 9 16:09:17 2021 -0500

        "private" is part of name mangling

    commit 351a45f61d63e26fbd379516f073876bf5558050
    Author: Dan Smith <[email protected]>
    Date:   Thu Dec 9 15:54:13 2021 -0500

        more xml.lite updates from coda-oss

    commit 1c72ba2639502de8e0036c5efc12ea5a2df7b983
    Author: Dan Smith <[email protected]>
    Date:   Thu Dec 9 15:15:34 2021 -0500

        trying to fine the right macro for SWIG

    commit 8d6e11d803e167835ab3adb09bc96e18f7ac5d41
    Author: Dan Smith <[email protected]>
    Date:   Thu Dec 9 14:51:34 2021 -0500

        need updates to Python bindings too

    commit e208dd4d072fd9f18860e84f54d68efdebef49a9
    Author: Dan Smith <[email protected]>
    Date:   Thu Dec 9 14:41:12 2021 -0500

        xml.lite changes from coda-oss

    commit 169df75cb962580fa63f1be3fbf9189c1fd74915
    Author: Dan Smith <[email protected]>
    Date:   Wed Dec 8 14:32:37 2021 -0500

        latest from coda-oss

commit 440b35119af990f001975c50d4b72524e2cb682b
Author: Dan Smith <[email protected]>
Date:   Mon Apr 18 12:39:22 2022 -0400

    Squashed commit of the following:

    commit 05fc1f8d2b499d58e79a3fc4dc7961f88fb290bf
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:35:39 2022 -0400

        account for change to nitf::MemorySource

    commit 01d65e595015b143007ad1c414d68bed41b0eb65
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:25:00 2022 -0400

        Update ReleaseNotes.md

    commit 5296635b2c7a02d9b632568ff8f274df69c0239d
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:17:55 2022 -0400

        latest from "nitro"

    commit 543bf38718e98f81b9a43d3299941243ab59f7a5
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:16:02 2022 -0400

        latest from coda-oss

    commit f8fb45a1ef2b0c766a8fff532fc35ce48bae2be3
    Merge: 043d37c66 844a356ba
    Author: Dan Smith <[email protected]>
    Date:   Mon Apr 18 12:09:02 2022 -0400

        Merge branch 'master' into develop/update-externals

    commit 043d37c664378bd523c86e23d81f594d7f165b62
    Author: Dan Smith <[email protected]>
    Date:   Thu Feb 24 08:26:22 2022 -0500

        unit tests that don't work in "externals"

    commit 2df69b20f74ac2b56e4e07c5e74a7c226230faf3
    Author: J. Daniel Smith <[email protected]>
    Date:   Wed Feb 23 21:30:32 2022 -0500

        imageCompression() now returns an "enum"

    commit b378acef90d1bcee7b3844ec830b5a10f68ff9a6
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 23 17:28:50 2022 -0500

        latest from "nitro"

    commit cc10dba53875a84f58f43321279fe67d3b12735c
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 23 17:23:35 2022 -0500

        latest from coda-oss

    commit c08a0cebb45496c10efc929e65f646f8ba3c182d
    Author: Dan Smith <[email protected]>
    Date:   Wed Feb 23 13:45:48 2022 -0500

        …
  • Loading branch information
J. Daniel Smith committed Aug 25, 2023
1 parent 776c65c commit 80128f8
Show file tree
Hide file tree
Showing 33 changed files with 70 additions and 73 deletions.
6 changes: 2 additions & 4 deletions UnitTest/CppUnitTestAssert.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "pch.h"
#include "TestCase.h"

#include "str/EncodedStringView.h"
#include "str/Encoding.h"

using namespace Microsoft::VisualStudio::CppUnitTestFramework;

Expand Down Expand Up @@ -37,7 +37,5 @@ void test::Assert::FailOnCondition(bool condition, const unsigned short* message
std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller
std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message)
{
const str::EncodedStringView vExpected(expected);
const str::EncodedStringView vActual(actual);
return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call!
return ::GetAssertMessage(equality, str::toWString(expected), str::toWString(actual), message); // and call!
}
4 changes: 2 additions & 2 deletions UnitTest/TestCase.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#include "CppUnitTest.h"
#include <include/TestCase.h>
#include <str/EncodedStringView.h>
#include <str/Encoding.h>

#undef TEST_CHECK
#undef TEST_ASSERT
Expand Down Expand Up @@ -89,7 +89,7 @@ inline void assert_almost_eq(const std::string& testName, long double X1, long d
#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2)

#undef TEST_FAIL
#define TEST_FAIL(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); }
#define TEST_FAIL(msg) { (void)testName; const auto vw(str::toWString(msg)); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.c_str()); }

#undef TEST_EXCEPTION
#undef TEST_THROWS
Expand Down
2 changes: 1 addition & 1 deletion UnitTest/pch.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data
#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed
#pragma warning(disable: 5039) // '...' : pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception.
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor

// TODO: get rid of these someday? ... from Visual Studio code-analysis
#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable(type.6).
Expand Down Expand Up @@ -63,7 +64,6 @@
#include <import/mt.h>
#pragma warning(pop)
#include <import/str.h>
#include <str/EncodedStringView.h>
#include <import/logging.h>
#include <math/Utilities.h>
#include <xml/lite/Element.h>
Expand Down
1 change: 0 additions & 1 deletion externals/nitro/modules/c++/nitf/include/nitf/Enum.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
#include <new> // std::nothrow

#include "str/Manip.h"
#include "str/EncodedStringView.h"

namespace nitf
{
Expand Down
1 change: 1 addition & 0 deletions externals/nitro/modules/c++/pch.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ CODA_OSS_disable_warning_pop
#pragma warning(disable: 26458) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4).
#pragma warning(disable: 26486) // Don't pass a pointer that may be invalid to a function. Parameter '...' in call to '...' may be invalid (lifetime.3).
#pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid(lifetime.4).
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor

// Yes, these are our files ... but they don't change very often, and if they do
// change we want to rebuild everything anyway.
Expand Down
1 change: 1 addition & 0 deletions six/modules/c++/cphd/framework.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed
#pragma warning(disable: 4127) // conditional expression is constant
#pragma warning(disable: 5039) // '...' : pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception.
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor

// TODO: get rid of these someday? ... from Visual Studio code-analysis
#pragma warning(disable: 26451) // Arithmetic overflow : Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '*' to avoid overflow(io.2).
Expand Down
7 changes: 4 additions & 3 deletions six/modules/c++/cphd/source/CPHDXMLControl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,12 @@
#include <memory>
#include <iterator>
#include <stdexcept>
#include <std/string>

#include <io/StringStream.h>
#include <logging/NullLogger.h>
#include <xml/lite/MinidomParser.h>
#include <str/EncodedStringView.h>
#include <str/Encoding.h>

#include <six/XMLControl.h>
#include <six/XmlLite.h>
Expand Down Expand Up @@ -89,7 +90,7 @@ std::string CPHDXMLControl::toXMLString_(
bool prettyPrint)
{
const auto result = toXMLString(metadata, schemaPaths, prettyPrint);
return str::EncodedStringView(result).native();
return str::toString(result);
}

std::unique_ptr<xml::lite::Document> CPHDXMLControl::toXML(
Expand Down Expand Up @@ -161,7 +162,7 @@ std::unique_ptr<Metadata> CPHDXMLControl::fromXML(const std::string& xmlString,
std::transform(schemaPaths_.begin(), schemaPaths_.end(), std::back_inserter(schemaPaths),
[](const std::string& s) { return s; });

return fromXML(str::EncodedStringView(xmlString).u8string(), schemaPaths);
return fromXML(str::u8FromString(xmlString), schemaPaths);
}
std::unique_ptr<Metadata> CPHDXMLControl::fromXML(const std::u8string& xmlString,
const std::vector<std::filesystem::path>& schemaPaths)
Expand Down
4 changes: 3 additions & 1 deletion six/modules/c++/cphd/source/Channel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
*/
#include <cphd/Channel.h>

#include <str/EncodedStringView.h>
#include <std/string>

#include <str/Encoding.h>

#include <six/Init.h>

Expand Down
2 changes: 2 additions & 0 deletions six/modules/c++/cphd03/framework.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed
#pragma warning(disable: 4127) // conditional expression is constant
#pragma warning(disable: 5039) // '...' : pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception.
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor


// TODO: get rid of these someday? ... from Visual Studio code-analysis
#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable(type.6).
Expand Down
10 changes: 5 additions & 5 deletions six/modules/c++/cphd03/source/CPHDXMLControl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
*/
#include <cphd03/CPHDXMLControl.h>

#include <string>
#include <std/string>
#include <std/memory>

#include <io/StringStream.h>
#include <logging/NullLogger.h>
#include <str/EncodedStringView.h>
#include <str/Encoding.h>
#include <six/Utilities.h>
#include <six/XmlLite.h>

Expand Down Expand Up @@ -70,11 +70,11 @@ std::u8string CPHDXMLControl::toXMLString(const Metadata& metadata)
io::U8StringStream ss;
doc->getRootElement()->print(ss);

return str::EncodedStringView("<?xml version=\"1.0\"?>").u8string() + ss.stream().str();
return str::u8FromString("<?xml version=\"1.0\"?>") + ss.stream().str();
}
std::string CPHDXMLControl::toXMLString_(const Metadata& metadata)
{
return str::EncodedStringView(toXMLString(metadata)).native();
return str::toString(toXMLString(metadata));
}

size_t CPHDXMLControl::getXMLsize(const Metadata& metadata)
Expand Down Expand Up @@ -493,7 +493,7 @@ XMLElem CPHDXMLControl::areaSampleDirectionParametersToXML(

std::unique_ptr<Metadata> CPHDXMLControl::fromXML(const std::string& xmlString)
{
auto result = fromXML(str::EncodedStringView(xmlString).u8string());
auto result = fromXML(str::u8FromString(xmlString));
return std::unique_ptr<Metadata>(result.release());
}
std::unique_ptr<Metadata> CPHDXMLControl::fromXML(const std::u8string& xmlString)
Expand Down
1 change: 1 addition & 0 deletions six/modules/c++/samples/check_valid_six.dir/pch.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data
#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed
#pragma warning(disable: 5039) // '...' : pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception.
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor

// TODO: get rid of these someday? ... from Visual Studio code-analysis
#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable(type.6).
Expand Down
1 change: 1 addition & 0 deletions six/modules/c++/samples/crop_sicd.dir/pch.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data
#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed
#pragma warning(disable: 5039) // '...' : pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception.
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor

// TODO: get rid of these someday? ... from Visual Studio code-analysis
#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable(type.6).
Expand Down
1 change: 1 addition & 0 deletions six/modules/c++/scene/framework.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#pragma warning(disable: 26458) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4).
#pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1).
#pragma warning(disable: 26822) // Dereferencing a null pointer 'me' (lifetime.1).
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor

#include "nitro_pch.h"

Expand Down
1 change: 1 addition & 0 deletions six/modules/c++/six.convert/framework.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified
#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed
#pragma warning(disable: 5264) // '...': '...' variable is not used
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor

#pragma warning(disable: 26812) // The enum type '...' is unscoped. Prefer '...' over '...' (Enum.3).

Expand Down
3 changes: 2 additions & 1 deletion six/modules/c++/six.sicd/framework.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@
#pragma warning(disable: 6262) // Function uses '...' bytes of stack : exceeds analyze : stacksize '...'.Consider moving some data to heap.
#pragma warning(disable: 26432) // If you define or delete any default operation in the type '...', define or delete them all(c.21).
#pragma warning(disable: 26458) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4).
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor

// too hard to get write with older C++11 compilers
// too hard to get right with older C++11 compilers
#pragma warning(disable: 26497) // The function '...' could be marked constexpr if compile-time evaluation is desired(f.4).


Expand Down
2 changes: 0 additions & 2 deletions six/modules/c++/six.sicd/source/Antenna.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
*/
#include <six/sicd/Antenna.h>

#include <str/EncodedStringView.h>

#include <six/Utilities.h>

namespace six
Expand Down
6 changes: 3 additions & 3 deletions six/modules/c++/six.sicd/source/Utilities.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
#include <mem/ScopedAlignedArray.h>
#include <gsl/gsl.h>
#include <str/Manip.h>
#include <str/EncodedStringView.h>
#include <str/Encoding.h>
#include <sys/Conf.h>
#include <sys/Span.h>
#include <types/RowCol.h>
Expand Down Expand Up @@ -1023,7 +1023,7 @@ std::unique_ptr<ComplexData> Utilities::parseDataFromString(
const std::vector<std::string>& schemaPaths_,
logging::Logger& log)
{
const auto xmlStr = str::EncodedStringView(xmlStr_).u8string();
const auto xmlStr = str::u8FromString(xmlStr_);

std::vector<std::filesystem::path> schemaPaths;
std::transform(schemaPaths_.begin(), schemaPaths_.end(), std::back_inserter(schemaPaths),
Expand All @@ -1048,7 +1048,7 @@ std::string Utilities::toXMLString(const ComplexData& data,
[](const std::string& s) { return s; });

const auto result = toXMLString(data, &schemaPaths, logger);
return str::EncodedStringView(result).native();
return str::toString(result);
}
std::u8string Utilities::toXMLString(const ComplexData& data,
const std::vector<std::filesystem::path>* pSchemaPaths, logging::Logger* pLogger)
Expand Down
25 changes: 10 additions & 15 deletions six/modules/c++/six.sicd/unittests/test_valid_six.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

#include <stdlib.h>

#include <string>
#include <std/string>
#include <iostream>
#include <string>
#include <utility>
Expand All @@ -35,7 +35,7 @@
#include <io/FileInputStream.h>
#include <logging/NullLogger.h>
#include <import/sys.h>
#include <str/EncodedStringView.h>
#include <str/Encoding.h>
#include <sys/Span.h>

#include <import/six.h>
Expand Down Expand Up @@ -152,13 +152,13 @@ TEST_CASE(valid_six_50x50)
valid_six_50x50_(testName, &schemaPaths_); // "validate" against schema (use a default path)
}

inline static std::string classificationText_iso8859_1()
inline static std::string classificationText_asIso8859_1()
{
return std::string("NON CLASSIFI\xc9 / UNCLASSIFIED"); // ISO8859-1 "NON CLASSIFIÉ / UNCLASSIFIED"
return "NON CLASSIFI\xc9 / UNCLASSIFIED"; // ISO8859-1 "NON CLASSIFIÉ / UNCLASSIFIED"
}
inline static std::string classificationText_utf_8()
inline static std::string classificationText_asUtf8()
{
return std::string("NON CLASSIFI\xc3\x89 / UNCLASSIFIED"); // UTF-8 "NON CLASSIFIÉ / UNCLASSIFIED"
return "NON CLASSIFI\xc3\x89 / UNCLASSIFIED"; // UTF-8 "NON CLASSIFIÉ / UNCLASSIFIED"
}

TEST_CASE(sicd_French_xml)
Expand All @@ -169,7 +169,7 @@ TEST_CASE(sicd_French_xml)
const auto image = six::sicd::readFromNITF(inputPathname, &schemaPaths_, pComplexData);
const six::Data* pData = pComplexData.get();

const auto expectedCassificationText = sys::Platform == sys::PlatformType::Linux ? classificationText_utf_8() : classificationText_iso8859_1();
const auto expectedCassificationText = sys::Platform == sys::PlatformType::Linux ? classificationText_asUtf8() : classificationText_asIso8859_1();
const auto& classification = pData->getClassification();
const auto actual = classification.getLevel();
TEST_ASSERT_EQ(actual, expectedCassificationText);
Expand Down Expand Up @@ -218,9 +218,8 @@ static bool find_string(io::FileInputStream& stream, const std::string& s)
stream.seek(pos, io::Seekable::START);
return false;
}
static void sicd_French_xml_raw_()
TEST_CASE(sicd_French_xml_raw)
{
static const std::string testName("test_valid_six");
// This is a binary file with XML burried in it somewhere
const auto path = six::testing::getNitfPath("sicd_French_xml.nitf");

Expand All @@ -234,24 +233,20 @@ static void sicd_French_xml_raw_()
const auto& classificationXML = root.getElementByTagName("Classification", true /*recurse*/);

// UTF-8 characters in sicd_French_xml.nitf
const auto expectedCharData = sys::Platform == sys::PlatformType::Linux ? classificationText_utf_8() : classificationText_iso8859_1();
const auto expectedCharData = sys::Platform == sys::PlatformType::Linux ? classificationText_asUtf8() : classificationText_asIso8859_1();
auto expectedLength = expectedCharData.length();
const auto characterData = classificationXML.getCharacterData();
TEST_ASSERT_EQ(characterData.length(), expectedLength);
TEST_ASSERT_EQ(characterData, expectedCharData);

const auto u8_expectedCharData8 = str::EncodedStringView::fromUtf8(classificationText_utf_8()).u8string();
const std::u8string u8_expectedCharData8 = str::c_str<std::u8string>(classificationText_asUtf8());
expectedLength = u8_expectedCharData8.length();

std::u8string u8_characterData;
classificationXML.getCharacterData(u8_characterData);
TEST_ASSERT_EQ(u8_characterData.length(), expectedLength);
TEST_ASSERT(u8_characterData == u8_expectedCharData8);
}
TEST_CASE(sicd_French_xml_raw)
{
sicd_French_xml_raw_();
}

static void test_assert(const six::sicd::ComplexData& complexData,
six::PixelType expectedPixelType, size_t expectedNumBytesPerPixel)
Expand Down
3 changes: 2 additions & 1 deletion six/modules/c++/six.sidd/framework.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@
#pragma warning(disable: 6262) // Function uses '...' bytes of stack : exceeds analyze : stacksize '...'.Consider moving some data to heap.
#pragma warning(disable: 26432) // If you define or delete any default operation in the type '...', define or delete them all(c.21).
#pragma warning(disable: 26458) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4).
#pragma warning(disable: 5267) // definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor


// too hard to get write with older C++11 compilers
// too hard to get right with older C++11 compilers
#pragma warning(disable: 26497) // The function '...' could be marked constexpr if compile-time evaluation is desired(f.4).


Expand Down
6 changes: 3 additions & 3 deletions six/modules/c++/six.sidd/source/GeoTIFFReadControl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include <std/memory>

#include <str/Convert.h>
#include <str/EncodedStringView.h>
#include <str/Encoding.h>
#include <gsl/gsl.h>
#include <mem/ScopedArray.h>
#include "six/sidd/GeoTIFFReadControl.h"
Expand Down Expand Up @@ -59,7 +59,7 @@ void parseXMLEntry(const tiff::IFDEntry *entry,
str::trim(curStr);
if (!curStr.empty())
{
entries.emplace_back(str::EncodedStringView(curStr).u8string());
entries.emplace_back(str::u8FromString(curStr));
curStr.clear();
}
}
Expand All @@ -75,7 +75,7 @@ void parseXMLEntry(const tiff::IFDEntry *entry,
str::trim(curStr);
if (!curStr.empty())
{
entries.emplace_back(str::EncodedStringView(curStr).u8string());
entries.emplace_back(str::u8FromString(curStr));
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions six/modules/c++/six.sidd/source/GeoTIFFWriteControl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include <stdexcept>

#include "io/FileOutputStream.h"
#include "str/EncodedStringView.h"
#include "str/Encoding.h"
#include "sys/Path.h"
#include "gsl/gsl.h"
#include "scene/GridECEFTransform.h"
Expand Down Expand Up @@ -236,12 +236,12 @@ void GeoTIFFWriteControl::setupIFD(const DerivedData* data,
tiff::IFDEntry* const xmlEntry = (*ifd)[Constants::GT_XML_TAG];

auto xml = six::toValidXMLString(data, schemaPaths, mLog);
xmlEntry->addValues(str::EncodedStringView(xml).native());
xmlEntry->addValues(str::toString(xml));

for (size_t jj = 0; jj < mComplexData.size(); ++jj)
{
xml = six::toValidXMLString(mComplexData[jj], schemaPaths, mLog);
xmlEntry->addValues(str::EncodedStringView(xml).native());
xmlEntry->addValues(str::toString(xml));
}
}

Expand Down
Loading

0 comments on commit 80128f8

Please sign in to comment.