Release Assets workflow update #1364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley
reviewed
Oct 24, 2025
|
|
||
| permissions: | ||
| contents: read | ||
| contents: write |
Collaborator
There was a problem hiding this comment.
why do you need write permissions?
Contributor
Author
There was a problem hiding this comment.
Needed to upload the packages to the release draft
Contributor
Author
|
Closing for now, will re-open when ready to be merged to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updates the
package-check.shscript to automatically add FreeBSD packages if the requested version isv2.x.The
upload-release-assets.ymlcan be used to pull signednginx-agentpackages from our official repositories, this works for any version. Once merged we should use this workflow for futurev2.xreleases similar to what we do withv3.x.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)