Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lua Parsing #982

Merged
merged 6 commits into from
Mar 6, 2025
Merged

Fix Lua Parsing #982

merged 6 commits into from
Mar 6, 2025

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Feb 14, 2025

Proposed changes

Added lua crossplane settings to fix errors occurring when parsing configs which contain lua

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Feb 14, 2025
@aphralG aphralG requested a review from a team as a code owner February 14, 2025 10:34
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Feb 14, 2025
@aphralG aphralG requested a review from RRashmit February 18, 2025 13:55
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Mar 6, 2025
@RRashmit
Copy link

RRashmit commented Mar 6, 2025

Testing:

Config apply successful with lua module. Agents logs has no errors and conf test is successful.

image
image

@aphralG aphralG merged commit 0c9d46b into v3 Mar 6, 2025
20 checks passed
@aphralG aphralG deleted the fix-lua-parsing branch March 6, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@sean-breen sean-breen sean-breen approved these changes

@RRashmit RRashmit RRashmit approved these changes

Assignees

@aphralG aphralG

Labels
bug Something isn't working chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aphralG @RRashmit @dhurley @sean-breen @oCHRISo