Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Reorg repo structure and add CODEOWNERS #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Apr 4, 2025

Proposed changes

Reorganized the overall repo structure so that demos are categorized by product offering; and add explicit CODEOWNERS for each demo.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@Copilot Copilot bot review requested due to automatic review settings April 4, 2025 14:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 137 out of 138 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • .github/CODEOWNERS: Language not supported
Comments suppressed due to low confidence (2)

CHANGELOG.md:1

  • The removal of CHANGELOG entries may lead to loss of project version history. If this deletion is unintentional, consider archiving the old entries instead of removing them completely.
## 1.0.0 (Month Date, Year) ... Initial release of this project.

.github/workflows/ossf_scorecard.yml:11

  • The branch filter was reduced to only 'main', removing 'master'. Please verify that this change reflects the current branch usage for the repository.
branches: [main]

README.md Outdated
|NGINX SOAP REST|Example NGINX configuration to translate between SOAP and REST|
|Title|Description|Owner|
|-----|-----------|-----|
|NGINX Advanced Healthcheck|Advanced active healthchecks for NGINX Plus||
Copy link
Preview

Copilot AI Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Owner column for the 'NGINX Advanced Healthcheck' demo is empty. Please add the appropriate CODEOWNER or a placeholder if no owner is designated.

Suggested change
|NGINX Advanced Healthcheck|Advanced active healthchecks for NGINX Plus||
|NGINX Advanced Healthcheck|Advanced active healthchecks for NGINX Plus|TBD|

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@alessfg alessfg force-pushed the structure-codeowners branch 2 times, most recently from 708e4de to ddb3db3 Compare April 4, 2025 19:04
@alessfg alessfg requested a review from Copilot April 4, 2025 19:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 115 out of 116 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .github/CODEOWNERS: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/ossf_scorecard.yml:11

  • Limiting branch filtering to 'main' may exclude updates from the 'master' branch if it is still in use. Please verify that this change is intentional.
+    branches: [main]

@alessfg alessfg force-pushed the structure-codeowners branch from ddb3db3 to 3ca900e Compare April 10, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant