Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules: adding NUL byte at the end of the module body. #742

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Modules: adding NUL byte at the end of the module body. #742

merged 1 commit into from
Jun 29, 2024

Conversation

xeioex
Copy link
Contributor

@xeioex xeioex commented Jun 21, 2024

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes

@xeioex
Modules: adding NUL byte at the end of the module body.
0abc53e 
Even though QuickJS takes length as an argument, when parsing the code,
it expects NUL byte at the end.
@xeioex xeioex requested a review from VadimZhestikov June 21, 2024 00:40
@xeioex xeioex merged commit 184d2a3 into nginx:master Jun 29, 2024
1 check passed
@xeioex xeioex deleted the add_nul_to_read_body branch June 29, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadimZhestikov VadimZhestikov VadimZhestikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xeioex @VadimZhestikov