Fixed "global" property handler. #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes nginx#734 issue.
VadimZhestikov
approved these changes
Jun 30, 2024
|
Just a side note: in contrast to njs, qjs do not support global variable/property "global". (but node, chrome, firefox all support global). So this can be considered as compatibility issue when moving from njs to qjs. May be we need add "global" to qjs run-time environment at our initialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #734 issue.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument