Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packaging sources to build packages on non-mainstream architectures. #922

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

thresheek
Copy link
Collaborator

Proposed changes

Similarly to what's currently happening on Alpine, use pkg-oss sources to build packages from source on Debian. This allows us to provide fixes for architectures not covered by upstream nginx.org packages (amd64, aarch64) without touching the rest of infrastructure on nginx.org.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

Copy link
Collaborator

@defanator defanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Minor comments inside.

Dockerfile-debian-otel.template Show resolved Hide resolved
Dockerfile-debian-perl.template Show resolved Hide resolved
Dockerfile-debian.template Show resolved Hide resolved
mainline/debian-otel/Dockerfile Show resolved Hide resolved
mainline/debian-perl/Dockerfile Show resolved Hide resolved
mainline/debian/Dockerfile Show resolved Hide resolved
stable/debian-otel/Dockerfile Show resolved Hide resolved
stable/debian-perl/Dockerfile Show resolved Hide resolved
stable/debian/Dockerfile Show resolved Hide resolved
@thresheek thresheek merged commit f0fc31f into nginxinc:master Sep 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants