Skip to content

Commit

Permalink
remove old hack
Browse files Browse the repository at this point in the history
  • Loading branch information
4141done committed Nov 14, 2023
1 parent 9df3b22 commit 070304f
Showing 1 changed file with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,6 @@ def _docker_pull(self, image_name: str) -> str:
:return full image name with server name (e.g. docker.io/library/debian:buster-slim)
"""

# The below is a hack for arm systems in which ECR wants
# all architectures in the manifest to exist locally on push
# only the linux/amd64 image will actually be used. I'm aware this is very wasteful but the workaround eludes me at the moment
# manifest_architectures = ["linux/arm/v7", "linux/arm64", "linux/ppc64le", "linux/s390x"]
# (this is still not working but a workaround is disabling containerd)
# for arch in manifest_architectures:
# cmd = f'docker pull --platform "{arch}" --quiet "{image_name}"'
# res, _ = self._run_docker(cmd=cmd)

cmd = f'docker pull --platform linux/amd64 --quiet "{image_name}"'
res, _ = self._run_docker(cmd=cmd)
image_name = res.strip()
Expand Down

0 comments on commit 070304f

Please sign in to comment.