-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6679 add globalConfigurationCustomName parameter #6680
base: main
Are you sure you want to change the base?
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
Add globalConfigurationCustomName parameter to controller configuration in helm chart (nginxinc#6679)
for more information, see https://pre-commit.ci
Hi @frantsao, I just tested this out, and it works well. Thanks again for working on it. There's one other thing that would be ideal: if the customName and create options could work together. This would require an update to this file to use the name and namespace parts of the customName, if it exists. The logic in _helpers.tpl would also need to be adjusted slightly to accommodate this change. |
Ok, I think it's a good idea too, but I didn't know if the change could be interesting for you too. I'll work on it as soon as I have some free time again :-) |
Hi @frantsao, |
Proposed changes
Add globalConfigurationCustomName parameter to controller confuguration in helm charts. It is helpful when the GlobalConfiguration is created separately from the helm provisioning, as explained in #6679
Checklist
Before creating a PR, run through this checklist and mark each as complete.