Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6679 add globalConfigurationCustomName parameter #6680

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

frantsao
Copy link

@frantsao frantsao commented Oct 17, 2024

Proposed changes

Add globalConfigurationCustomName parameter to controller confuguration in helm charts. It is helpful when the GlobalConfiguration is created separately from the helm provisioning, as explained in #6679

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@frantsao
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

Add globalConfigurationCustomName parameter to controller
configuration in helm chart (nginxinc#6679)
@frantsao frantsao marked this pull request as ready for review October 18, 2024 12:38
@frantsao frantsao requested a review from a team as a code owner October 18, 2024 12:38
@j1m-ryan
Copy link
Member

Hi @frantsao,

I just tested this out, and it works well. Thanks again for working on it. There's one other thing that would be ideal: if the customName and create options could work together.

This would require an update to this file to use the name and namespace parts of the customName, if it exists.

The logic in _helpers.tpl would also need to be adjusted slightly to accommodate this change.

@frantsao
Copy link
Author

Hi @frantsao,

I just tested this out, and it works well. Thanks again for working on it. There's one other thing that would be ideal: if the customName and create options could work together.

This would require an update to this file to use the name and namespace parts of the customName, if it exists.

The logic in _helpers.tpl would also need to be adjusted slightly to accommodate this change.

Ok, I think it's a good idea too, but I didn't know if the change could be interesting for you too. I'll work on it as soon as I have some free time again :-)

@j1m-ryan
Copy link
Member

Hi @frantsao,
No worries at all, take your time. When you look at this again, you might find that making definitions in _helpers.tpl could be useful for getting the name and namespace defined. You can then use the defintions in the global configuration template file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm_chart Pull requests that update the Helm Chart
Projects
Status: Todo ☑
Development

Successfully merging this pull request may close these issues.

2 participants