Skip to content

Conversation

@lamATnginx
Copy link
Collaborator

Proposed changes

  • Added test for product selector
  • Removed overlap from needing to test every single link and dropdown.
  • Removed unneeded product-selector.js

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Nov 10, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner November 10, 2025 22:51
@lamATnginx lamATnginx added the enhancement New feature or request label Nov 10, 2025
@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/451/

@lamATnginx
Copy link
Collaborator Author

lamATnginx commented Nov 10, 2025

As seen in the workflow, we have made a huge improvement from 2-3 minutes on the running test step to just ~1 minute.

Copy link
Member

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally approved :)

Tests are speeding along locally and I'm not getting those random failures I was getting pre-refactor 🥳

One clarifying question around whether a state is valid/invalid.

@lamATnginx lamATnginx merged commit 4c57ed5 into main Nov 11, 2025
7 checks passed
@lamATnginx lamATnginx deleted the refactor/sidebar-test branch November 11, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants