Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dialogs that don't block scrolling behind backdrop #116

Open
Tlepel opened this issue Nov 22, 2023 · 3 comments
Open

Create dialogs that don't block scrolling behind backdrop #116

Tlepel opened this issue Nov 22, 2023 · 3 comments

Comments

@Tlepel
Copy link
Contributor

Tlepel commented Nov 22, 2023

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Whenever a modal is opened, the overflow of the body will be hidden

Expected behavior

Modals can be created that don't necessarily have to hide the overflow. If all open modals have this setting, the body shouldn't get the overflow: hidden property. If any of the modals doesn't have this setting, it should behave the same as before.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

We sometimes use the modals as an information-overlay. However, the information is an addition to the page contents of that moment. The modal backdrop helps in this case, since it disables clicks on elements on the page, but it would be beneficial if the page contents could still be scrollable.

@Tlepel
Copy link
Contributor Author

Tlepel commented Nov 22, 2023

I'm fine with giving this a try myself by the way, seems like an interesting challenge.

@netanel-utila
Copy link

You are welcome to create a PR

@netanel-utila
Copy link

Try to check the angular material dialog impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants