feat: overflow functionality #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -32,6 +32,7 @@ export interface GlobalDialogConfig { | |||
| backdrop: CloseStrategy; | |||
| }; | |||
| resizable: boolean; | |||
| overflow: boolean; | |||
There was a problem hiding this comment.
Any reason we need this property?
There was a problem hiding this comment.
This is part of the config to allow the user to choose whether they want overflow on the body when the dialog is open or not.
| @@ -97,6 +99,6 @@ | |||
| } | |||
| } | |||
|
|
|||
| body.ngneat-dialog-hidden { | |||
| body.ngneat-dialog-hidden:not(.overflow) { | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
We can use a CSS variable instead of a class:
overflow: var(--dialog-overflow, hidden);
There was a problem hiding this comment.
Okay, I'm not sure whether this is preferable in this case, but if this is what you prefer, no problem :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type - Feature
Resolving Issue Number: #116