Merge pull request #90 from Pilpin/master

fix(dependencies): removing @ng-bootstrap/ng-bootstrap from the dependencies
ngneat · Mar 2, 2024 · aac1fc2 · aac1fc2
2 parents 7cbd688 + ef30dec
commit aac1fc2
Show file tree

Hide file tree

Showing 6 changed files with 103 additions and 97 deletions.
diff --git a/README.md b/README.md
@@ -168,6 +168,7 @@ export class AppComponent implements AfterViewInit {
     this.hotkeys.registerHelpModal(() => {
       const ref = this.modalService.open(HotkeysHelpComponent, { size: 'lg' });
       ref.componentInstance.title = 'Custom Shortcuts Title';
+      ref.componentInstance.dismiss.subscribe(() => ref.close());
     });
   }
 }

diff --git a/package-lock.json b/package-lock.json
diff --git a/projects/ngneat/hotkeys/src/lib/hotkeys-help/hotkeys-help.component.html b/projects/ngneat/hotkeys/src/lib/hotkeys-help/hotkeys-help.component.html
@@ -1,12 +1,8 @@
 <div class="modal-header">
   <div *ngIf="title" class="hotkeys-help-header">
     <span class="hotkeys-help-header-title">{{ title }}</span>
-    <button
-      type="button"
-      class="hotkeys-help-header-dismiss-button"
-      (click)="activeModal.dismiss('Cross click')"
-    ></button>
   </div>
+  <button type="button" class="hotkeys-help-header-dismiss-button" (click)="handleDismiss()">&#x2715;</button>
 </div>
 <div class="modal-body preview-modal-body">
   <table class="hotkeys-table-help" cellspacing="0" width="100%" *ngFor="let hotkeyGroup of hotkeys">

diff --git a/projects/ngneat/hotkeys/src/lib/hotkeys-help/hotkeys-help.component.scss b/projects/ngneat/hotkeys/src/lib/hotkeys-help/hotkeys-help.component.scss
@@ -43,7 +43,6 @@
 
   .hotkeys-help-header {
     font-size: 1.25em;
-    margin-bottom: 1.25em;
     display: flex;
     flex-direction: row;
     justify-content: space-between;
@@ -57,7 +56,7 @@
   .hotkeys-help-header-dismiss-button {
     border: none;
     font-size: 18px;
-    color: #9e9e9e;
+    background: transparent;
     cursor: pointer;
     &:focus {
       outline: none;