Skip to content

Commit

Permalink
Merge pull request #84 from gethari/master
Browse files Browse the repository at this point in the history
Upgrade to Angular 16
  • Loading branch information
NetanelBasal authored Sep 10, 2023
2 parents 02fc4bc + 0f6a5a2 commit d8da957
Show file tree
Hide file tree
Showing 14 changed files with 4,524 additions and 4,079 deletions.
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Web apps are getting closer and closer to be desktop-class applications. With th

| @ngneat/hotkeys | Angular |
| --------------- | ------- |
| 1.4.x | >=16 |
| 1.3.x | >=14 |
| 1.2.x | <=13 |

Expand Down Expand Up @@ -152,7 +153,7 @@ unsubscribe();
Display a help dialog listing all visible hotkeys:

```ts
import { MatDialog } from '@angular/material/dialog';
import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
import { HotkeysHelpComponent, HotkeysService } from '@ngneat/hotkeys';

@Component({
Expand All @@ -161,12 +162,12 @@ import { HotkeysHelpComponent, HotkeysService } from '@ngneat/hotkeys';
styleUrls: ['./app.component.css']
})
export class AppComponent implements AfterViewInit {
constructor(private hotkeys: HotkeysService, private dialog: MatDialog) {}
constructor(private hotkeys: HotkeysService, private dialog: NgbModal) {}

ngAfterViewInit() {
this.hotkeys.registerHelpModal(() => {
const ref = this.dialog.open(HotkeysHelpComponent, { width: '500px' });
ref.componentInstance.dismiss.subscribe(() => ref.close());
const ref = this.modalService.open(HotkeysHelpComponent, { size: 'lg' });
ref.componentInstance.title = 'Custom Shortcuts Title';
});
}
}
Expand Down
4 changes: 2 additions & 2 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"polyfills": "src/polyfills.ts",
"tsConfig": "tsconfig.app.json",
"assets": ["src/favicon.ico", "src/assets"],
"styles": ["./node_modules/@angular/material/prebuilt-themes/indigo-pink.css", "src/styles.css"],
"styles": ["node_modules/bootstrap/scss/bootstrap.scss", "src/styles.css"],
"scripts": [],
"vendorChunk": true,
"extractLicenses": false,
Expand Down Expand Up @@ -84,7 +84,7 @@
"tsConfig": "tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"assets": ["src/favicon.ico", "src/assets"],
"styles": ["./node_modules/@angular/material/prebuilt-themes/indigo-pink.css", "src/styles.css"],
"styles": ["src/styles.css"],
"scripts": []
}
},
Expand Down
Loading

0 comments on commit d8da957

Please sign in to comment.