Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signals): infer and narrow EntityId type in withEntities #4737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Chiorufarewerin
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #4570

Does this PR introduce a breaking change?

[X] Yes
[ ] No

Additional info

I have already submitted this PR, but after further consideration, I came up with an alternative solution. I prefer this new approach because EntityId is more narrowly typed and properly inferred. However, it introduces breaking changes...

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit ae7eb49
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67e1ce6d9189fa0008038767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC(@ngrx/signals): Add type of id as optional second type arg to withEntities<Entity,Id>()
1 participant