Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: RxJS chains #1137

Merged
merged 2 commits into from
Feb 5, 2020
Merged

refactor: RxJS chains #1137

merged 2 commits into from
Feb 5, 2020

Conversation

martinsik
Copy link
Contributor

@martinsik martinsik commented Nov 10, 2019

I went through the code base and refactored some RxJS usage where I thought it could be improved or where it was using old and deprecated notations. I'm adding comments where it's not obvious what I did there.

In general there are two larger changes:

All existing tests were passing I just added one more additional test for some sync behavior.

@martinsik martinsik requested a review from ocombe February 5, 2020 07:43
ocombe
ocombe previously approved these changes Feb 5, 2020
@ocombe
Copy link
Collaborator

ocombe commented Feb 5, 2020

@martinsik it looks great! You're really better at rxjs than I am 😁
could you rebase the branch on master so that the tests can run please? if it's all green then I'll merge it!

@ocombe ocombe merged commit 355f239 into ngx-translate:master Feb 5, 2020
@iamnaumovnikita
Copy link

Guys, as I know the function isObservable should consume obseravble, but in your code it consumes subscribe function.
So, I think this code "isObservable(res.subscribe)" should be chnaged to "isObservable(res)" @ocombe and @martinsik please take a look

@martinsik
Copy link
Contributor Author

martinsik commented Mar 5, 2023

@iamnaumovnikita
Copy link

iamnaumovnikita commented Mar 7, 2023

I hve created PR #1411 can you review it, please? @martinsik @ocombe
Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants