Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: v18 announcement tweaks #2179

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

markwhitfeld
Copy link
Member

This PR makes some modifications to the v18 announcement post, ahead of publication.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

Copy link

nx-cloud bot commented Jun 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 12f1131. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link

bundlemon bot commented Jun 26, 2024

BundleMon (Integration Projects)

Unchanged files (2)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
69.46KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
68.47KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@msmallest
Copy link

Will the root README.md be updated when this post is released, in a different PR?

I ask because having the root GitHub README.md differ from the docs one and NPM one, as well as v18 being released, has been a point of confusion for me about the formal status of the release and the messaging about it.

I know I can use v18 now, but I could see this being a point of confusion.

BTW nice release, good changes.

@arturovt arturovt force-pushed the markwhitfeld/v18-announcement-tweaks branch 2 times, most recently from 5ec4fa9 to 05edbcf Compare July 11, 2024 21:37
@arturovt arturovt force-pushed the markwhitfeld/v18-announcement-tweaks branch from 05edbcf to 12f1131 Compare July 11, 2024 21:37
Copy link

codeclimate bot commented Jul 11, 2024

Code Climate has analyzed commit 12f1131 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.4% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants