Skip to content

Conversation

bestmazzo
Copy link
Contributor

@bestmazzo bestmazzo commented May 13, 2024

Description

As stated in #208 there may be scenarios where s3 storage is configured with a subdomain structure ( ://{bucket_name}.{region}.provider.com ) instead of a path structure ( ://{region}.provider.com/{bucket_name} )
hasura-storage should be able to work accordingly, but we need to extend config params

Problem

So far hasura-storage ENV vars doesn't address this kind of s3 url structure description

Solution

We should see whether passing a ENV_USE_PATH_STYLE variable to s3 config options is enough

@dbarrosop
Copy link
Member

Hi, thanks for the contribution, a couple of minor comments.

@bestmazzo bestmazzo force-pushed the feat/usepathstyle branch 2 times, most recently from 0476733 to 3d8e6e8 Compare May 14, 2024 20:05
@bestmazzo
Copy link
Contributor Author

Hello, I've rebases PR based on updated main branch.

Copy link

stale bot commented May 20, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 20, 2025
@dbarrosop dbarrosop removed the stale label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants