Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use an older commit to avoid cold hydra cache issues #31

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Conversation

dbarrosop
Copy link
Member

@dbarrosop dbarrosop commented Jan 27, 2025

PR Type

Enhancement


Description

  • Uncomment PostgreSQL client packages in flake.nix

  • Enable multiple PostgreSQL client versions


Changes walkthrough 📝

Relevant files
Configuration changes
flake.nix
Enable multiple PostgreSQL client versions                             

flake.nix

  • Uncommented PostgreSQL client packages for versions 14.15, 15.10, and
    16.6
  • Kept PostgreSQL client 17.2 and server packages commented out
  • +3/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Use latest PostgreSQL client only

    Consider using only the latest PostgreSQL client version to avoid potential version
    conflicts and simplify dependency management.

    flake.nix [51-54]

    -postgresql_14_15-client
    -postgresql_15_10-client
    -postgresql_16_6-client
     postgresql_17_2-client
    Suggestion importance[1-10]: 3

    Why: While using only the latest PostgreSQL client could simplify dependency management, it may limit compatibility with different PostgreSQL versions. The PR intentionally adds multiple client versions, likely for a specific reason.

    3

    @dbarrosop dbarrosop changed the title asd fix: use an older commit to avoid cold hydra cache issues Jan 27, 2025
    @dbarrosop dbarrosop merged commit f63f3dd into main Jan 27, 2025
    2 checks passed
    @dbarrosop dbarrosop deleted the qwe branch January 27, 2025 15:34
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants