Skip to content

Commit

Permalink
Bump rubocop-govuk from 5.0.7 to 5.0.8 (#2895)
Browse files Browse the repository at this point in the history
Bumps [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) from
5.0.7 to 5.0.8.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md">rubocop-govuk's
changelog</a>.</em></p>
<blockquote>
<h1>5.0.8</h1>
<ul>
<li>Update dependencies</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/alphagov/rubocop-govuk/commit/502f5ad36cc1f0568fd2eab13861ac9020b94750"><code>502f5ad</code></a>
Merge pull request <a
href="https://redirect.github.com/alphagov/rubocop-govuk/issues/446">#446</a>
from alphagov/release-5.0.8</li>
<li><a
href="https://github.com/alphagov/rubocop-govuk/commit/ed0274aeb946747ccefc98d2be524da4a8726aeb"><code>ed0274a</code></a>
Release v5.0.8</li>
<li><a
href="https://github.com/alphagov/rubocop-govuk/commit/e85b5b286c7d2605a0090e2abf13366296e7493b"><code>e85b5b2</code></a>
Merge pull request <a
href="https://redirect.github.com/alphagov/rubocop-govuk/issues/445">#445</a>
from alphagov/dependabot/bundler/rubocop-eq-1.70.0</li>
<li><a
href="https://github.com/alphagov/rubocop-govuk/commit/c643a747b897ecae316e8b4e8082b78f67ab8271"><code>c643a74</code></a>
Update rubocop requirement from = 1.69.2 to = 1.70.0</li>
<li>See full diff in <a
href="https://github.com/alphagov/rubocop-govuk/compare/v5.0.7...v5.0.8">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=rubocop-govuk&package-manager=bundler&previous-version=5.0.7&new-version=5.0.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
  • Loading branch information
thomasleese authored Jan 28, 2025
2 parents ad8e9f3 + 13efff6 commit eea331f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
16 changes: 8 additions & 8 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ GEM
charlock_holmes (0.7.9)
childprocess (5.0.0)
coderay (1.1.3)
concurrent-ruby (1.3.4)
concurrent-ruby (1.3.5)
config (5.5.2)
deep_merge (~> 1.2, >= 1.2.1)
ostruct
Expand Down Expand Up @@ -292,7 +292,7 @@ GEM
htmlentities (4.3.4)
http-cookie (1.0.8)
domain_name (~> 0.5)
i18n (1.14.6)
i18n (1.14.7)
concurrent-ruby (~> 1.0)
io-console (0.8.0)
irb (1.14.3)
Expand Down Expand Up @@ -322,7 +322,7 @@ GEM
rexml
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
language_server-protocol (3.17.0.3)
language_server-protocol (3.17.0.4)
launchy (3.0.0)
addressable (~> 2.8)
childprocess (~> 5.0)
Expand Down Expand Up @@ -419,7 +419,7 @@ GEM
ostruct (0.6.0)
pagy (9.3.3)
parallel (1.26.3)
parser (3.3.6.0)
parser (3.3.7.0)
ast (~> 2.4.1)
racc
pg (1.5.9)
Expand Down Expand Up @@ -540,7 +540,7 @@ GEM
rspec-mocks (~> 3.13)
rspec-support (~> 3.13)
rspec-support (3.13.1)
rubocop (1.69.2)
rubocop (1.70.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
Expand All @@ -554,8 +554,8 @@ GEM
parser (>= 3.3.1.0)
rubocop-capybara (2.21.0)
rubocop (~> 1.41)
rubocop-govuk (5.0.7)
rubocop (= 1.69.2)
rubocop-govuk (5.0.8)
rubocop (= 1.70.0)
rubocop-ast (= 1.37.0)
rubocop-capybara (= 2.21.0)
rubocop-rails (= 2.28.0)
Expand Down Expand Up @@ -649,7 +649,7 @@ GEM
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
uk_postcode (2.1.8)
unicode-display_width (3.1.3)
unicode-display_width (3.1.4)
unicode-emoji (~> 4.0, >= 4.0.4)
unicode-emoji (4.0.4)
uri (1.0.2)
Expand Down
4 changes: 3 additions & 1 deletion lib/tasks/schools.rake
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ namespace :schools do
# Some URLs from the GIAS CSV are missing the protocol.
process_url = ->(url) do
return nil if url.blank?
url.start_with?("http://", "https://") ? url : "https://#{url}"

# Some school URLs don't start with http:// and https://
url = url.start_with?("http://", "https://") ? url : "https://#{url}"

# Legh Vale school has a URL of http:www.leghvale.st-helens.sch.uk
# which is not a valid URL.
Expand Down

0 comments on commit eea331f

Please sign in to comment.