Add Reply-To IDs to teams #2748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
govuk-parameters
branch
from
b4e8dac to
edfb80b
Compare
thomasleese
force-pushed
the
team-reply-to-id
branch
from
1a37c20 to
221cd03
Compare
thomasleese
force-pushed
the
team-reply-to-id
branch
from
221cd03 to
72094b1
Compare
thomasleese
force-pushed
the
team-reply-to-id
branch
from
72094b1 to
6e6828c
Compare
tvararu
approved these changes
Dec 15, 2024
thomasleese
force-pushed
the
team-reply-to-id
branch
from
6e6828c to
3451c29
Compare
thomasleese
force-pushed
the
team-reply-to-id
branch
from
3451c29 to
47ef73e
Compare
thomasleese
force-pushed
the
team-reply-to-id
branch
from
47ef73e to
4149eee
Compare
misaka
approved these changes
Dec 18, 2024
thomasleese
force-pushed
the
team-reply-to-id
branch
from
4149eee to
41845f6
Compare
thomasleese
force-pushed
the
team-reply-to-id
branch
from
41845f6 to
610c302
Compare
thomasleese
force-pushed
the
team-reply-to-id
branch
3 times, most recently
from
17ac0ee to
1d59d22
Compare
thomasleese
force-pushed
the
team-reply-to-id
branch
from
1d59d22 to
d028f19
Compare
thomasleese
force-pushed
the
team-reply-to-id
branch
3 times, most recently
from
089972e to
788fdb7
Compare
This adds a test checking the value of the `reply_to_id` matches one set in the organisation.
This will be used to store the GOV.UK Notify Reply-to UUID that's used if an email is sent in the context of a team. This value currently exists on organisations but not at a team level.
This updates the `ApplicationMailer` to use the `reply_to_id` value from a team if it's available, falling back to the organisation value if not.
This updates the onboarding task and example template to allow providing a `reply_to_id` for each team.
thomasleese
force-pushed
the
team-reply-to-id
branch
from
788fdb7 to
846eb5a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to customise the GOV.UK Notify Reply-To ID per team like we already do with contact details (phone and email) to ensure that if users reply to the email they will go to the right place.