-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow community clinic ODS codes to be optional #2778
Open
thomasleese
wants to merge
3
commits into
main
Choose a base branch
from
allow-optional-clinic-ods-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
added
🗄️ operations
Improving live support
🛠️ refactor
Improving maintainability
labels
Dec 18, 2024
tvararu
approved these changes
Dec 18, 2024
misaka
approved these changes
Dec 18, 2024
thomasleese
force-pushed
the
allow-optional-clinic-ods-code
branch
from
December 20, 2024 11:29
99d01e7
to
d53e1b3
Compare
thomasleese
force-pushed
the
allow-optional-clinic-ods-code
branch
from
December 20, 2024 14:34
d53e1b3
to
f87b379
Compare
thomasleese
force-pushed
the
allow-optional-clinic-ods-code
branch
5 times, most recently
from
January 9, 2025 08:54
e27505a
to
97bdebf
Compare
tvararu
approved these changes
Jan 9, 2025
thomasleese
force-pushed
the
allow-optional-clinic-ods-code
branch
2 times, most recently
from
January 13, 2025 16:52
54279f4
to
7e7440e
Compare
When onboarding Coventry we became aware that not all of the community clinics will have an ODS code, so we need to allow these to be optional. When optional, we would use the ODS code of the organisation when sending data downstream.
This doesn't have an ODS code registered for it, when onboarding we created our own fake one.
These are optional so we no longer need to provide them.
thomasleese
force-pushed
the
allow-optional-clinic-ods-code
branch
from
January 14, 2025 17:20
7e7440e
to
6668f6c
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When onboarding Coventry we became aware that not all of the community clinics will have an ODS code, so we need to allow these to be optional. When optional, we would use the ODS code of the organisation when sending data downstream.