Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cohort model #2784

Open
wants to merge 3 commits into
base: replace-cohort-with-organisation
Choose a base branch
from
Open

Remove Cohort model #2784

wants to merge 3 commits into from

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Dec 19, 2024 •
edited
Loading

In #2783 we've replaced the usage of the Cohort model with a directly foreign key relationship to the organisation. This means the model can be safely removed as it was no longer being used.

@thomasleese thomasleese added 📐 data_consistency Validations and data tweaks 🛠️ refactor Improving maintainability labels Dec 19, 2024
@thomasleese thomasleese added this to the v1.1.4 milestone Dec 19, 2024
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from 08af78b to e9533b0 Compare December 20, 2024 11:28
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from e9533b0 to f76bbf6 Compare December 20, 2024 14:35
@tvararu tvararu temporarily deployed to mavis-pr-2784 December 20, 2024 14:36 Inactive
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from f76bbf6 to e0ed571 Compare January 5, 2025 10:59
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch 2 times, most recently from 2b320bd to e8dfb1b Compare January 7, 2025 13:49
@thomasleese thomasleese force-pushed the remove-cohorts branch 2 times, most recently from 792a42e to 4336c91 Compare January 8, 2025 11:30
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch 2 times, most recently from e75047f to cd002d6 Compare January 8, 2025 13:51
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from cd002d6 to bc17344 Compare January 8, 2025 14:37
thomasleese added a commit that referenced this pull request Jan 8, 2025
@thomasleese
Avoid duplicate DATE_OF_BIRTH errors
0ca00ea 
This fixes a few minor visual issues spotted by the testers when testing
#2780 where
if the date of birth is missing the same error will appear twice for
each row, and similarly an issue where the year group wouldn't render
correctly.

This fixes are already in place for a future release (in
#2783 and
#2784),
however including them now makes the testing easier and avoids needing
to record additional defects.
@thomasleese thomasleese mentioned this pull request Jan 8, 2025
Merged
thomasleese added a commit that referenced this pull request Jan 8, 2025
@thomasleese
Avoid duplicate DATE_OF_BIRTH errors
0130357 
This fixes a few minor visual issues spotted by the testers when testing
#2780 where
if the date of birth is missing the same error will appear twice for
each row, and similarly an issue where the year group wouldn't render
correctly.

This fixes are already in place for a future release (in
#2783 and
#2784),
however including them now makes the testing easier and avoids needing
to record additional defects.
thomasleese added a commit that referenced this pull request Jan 8, 2025
@thomasleese
Avoid duplicate DATE_OF_BIRTH errors (#2826)
b284af2 
This fixes a few minor visual issues spotted by the testers when testing
#2780 where
if the date of birth is missing the same error will appear twice for
each row, and similarly an issue where the year group wouldn't render
correctly.

This fixes are already in place for a future release (in
#2783 and
#2784),
however including them now makes the testing easier and avoids needing
to record additional defects.

## Screenshots


![{CFD5D2F8-A8E7-40F1-B323-45361B94AB3A}](https://github.com/user-attachments/assets/fa2a0a2b-9ad0-4913-a71f-ea48ae7c82cf)

![{9A759A33-DF06-4FCC-9F59-9B9C8FF22271}](https://github.com/user-attachments/assets/eef016c9-47ad-4b14-8ced-5e2dd8e19427)
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from bc17344 to 91a9062 Compare January 9, 2025 08:55
@thomasleese thomasleese changed the title Remove cohorts Remove Cohort model Jan 15, 2025
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from a8b8972 to b3b43de Compare January 16, 2025 08:34
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from b3b43de to 4488ee2 Compare January 17, 2025 16:34
@thomasleese thomasleese modified the milestones: v1.5.0, 1.6.0 Jan 21, 2025
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from 4488ee2 to 7b8784c Compare January 21, 2025 17:51
@thomasleese thomasleese marked this pull request as ready for review January 21, 2025 18:38
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from 7b8784c to ae4d218 Compare January 22, 2025 10:50
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from ae4d218 to 797fb51 Compare January 22, 2025 14:28
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from 797fb51 to c884ec7 Compare January 23, 2025 16:48
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from c884ec7 to cdf8c37 Compare January 27, 2025 08:45
@thomasleese thomasleese force-pushed the remove-cohorts branch 2 times, most recently from ecdc1d5 to 6425f4c Compare January 28, 2025 08:36
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from cdf8c37 to 3c3ae04 Compare January 28, 2025 08:36
@thomasleese thomasleese force-pushed the replace-cohort-with-organisation branch from 3c3ae04 to 12c268b Compare January 28, 2025 11:08
@thomasleese
Remove cohorts table
0ffb85f 
This removes the table and the reference on the patient model as we no
longer need cohorts and they're not used anywhere.
@thomasleese
Remove Cohort
2cf8d17 
This removes the `Cohort` model and related code which is no longer
used.
@thomasleese
Remove YearGroupConcern
47b6689 
This removes the concern as it's only beind used by one model now.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvararu tvararu tvararu approved these changes

Assignees
No one assigned
Labels
📐 data_consistency Validations and data tweaks 🛠️ refactor Improving maintainability
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasleese @tvararu