Refactor SMS delivery #2840
Open
Refactor SMS delivery #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvararu
approved these changes
Jan 14, 2025
This encapsulates some logic related to sending emails and texts via GOV.UK Notify in to its own class so that in the future we can use this when sending emails. We need to refactor the way emails are sent to use the API directly so that we can integrate with the status receipts provided by GOV.UK and this is the first step of that.
This renames references to "texts" and instead replaces it with references to "SMS". This has no change on the behaviour but it matches the naming used by GOV.UK Notify so helps to keep the code consistent.
thomasleese
force-pushed
the
refactor-sms-delivery
branch
from
15a14cb to
a0bb987
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes related to delivery of text messages to support future work around refactoring email delivery to use the GOV.UK API directly, see individual commits for more details.
We need this so we can integrate with the status receipts provided by GOV.UK and control the retry behaviour on failures.