Validate batch numbers using separate worksheet(s). #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameterise this method so it can be used to create other reference sheets used in data validations.
This is to aid debugging where there is more than one worksheet; when instrospecting the code we want to be able to access different worksheets to check if they've been populated, which can't be done if we can't access the workbook.
Not sure how or why these got in in the first place, but it doesn't appear to be necessary to have a double equals sign "=".
This protects against Excel's 256 char limit for validation values by putting batch numbers into a separate sheet and looking them up there. https://trello.com/c/PVjQ6E6B/1826-refactor-batch-ids-drop-down-in-offline-spreadsheet
Performing professional emails and batch numbers aren't ordered when pulled out to populate the offline spreadsheet, so the ordering is non-deterministic.
misaka
force-pushed
the
offline-excel-batch-numbers
branch
from
f43756d to
3e96a50
Compare
tvararu
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Wondering if there's a Rubocop rule for it instead of _1
Edit: rubocop/rubocop#13597
thomasleese
reviewed
Jan 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the offline spreadsheet protects against Excel's 256 char limit for validation values by putting batch numbers into a separate sheet and looking them up there. This builds on the work done for the performing professionals validations.
https://trello.com/c/PVjQ6E6B/1826-refactor-batch-ids-drop-down-in-offline-spreadsheet
Batch number drop-down:
New data validation for batch numbers:
New sheet added for the specific programme (normally this sheet is hidden):
