Show progress bar for the GToJSONConverter #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does one cancel the conversion? Previously, I believe they could hit the 'Abort Run' button. |
That hadn't occurred to me. Would it be all right if I changed the subVI to be abortable like so? |
|
The title bar is distracting. You could probably make it like a one button dialog which aborts the vi when the button is clicked. You'll have to don your UX hat and figure out the workflows one could go through. |
|
ProgressBar.vi InitProgresssBar.vi UpdateProgressBar.vi CloseProgressBar.vi GetAbort.vi |
…into converter-progress-bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The converter looks quite unresponsive, especially while converting large projects. Adding a progress bar to fix this issue.
Implementation
Changes are made in GenerateHTML.vi to show the progress bar and the path of the file being converted. The front panel has been resized to show these, and is opened up as a dialog window when the converter is run.
