Changed Rich Text Viewer markdown property to an attribute #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The markdown property cannot be set from Blazor since Blazor does not support setting properties. To make available in Blazor, it needs to be an attribute and thus the reason for the change.
joseahdz
requested review from
rajsite,
jattasNI and
vivinkrishna-ni
as code owners
rajsite
reviewed
Feb 25, 2025
rajsite
reviewed
Feb 25, 2025
packages/nimble-components/src/rich-text/viewer/tests/rich-text-viewer.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Feb 25, 2025
rajsite
reviewed
Feb 25, 2025
rajsite
reviewed
Feb 25, 2025
packages/storybook/src/nimble/rich-text/viewer/rich-text-viewer.stories.ts
Show resolved
Hide resolved
rajsite
approved these changes
Feb 25, 2025
|
Minor change that should be no observable difference to exisiting users setting the property. Bypassing owners @jattasNI @vivinkrishna-ni |
joseahdz
added a commit
that referenced
this pull request
Feb 25, 2025
…ch-text-viewer * main: Changed Rich Text Viewer markdown property to an attribute (#2542)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The markdown property cannot be set from Blazor since Blazor does not currently support setting properties.
Some options are:
@observableproperty to an@attrproperty + attributeFor the rich text viewer
markdownproperty there does not seem to be a specific reason to avoid configuringmarkdownas an attribute.👩💻 Implementation
Changed markdown property from
observabletoattr. Also, updated story book to showmarkdownas an attribute instead of a property.The
fromViewmode will be used to avoid unnecessarily reflecting large strings set as properties back as attributes.🧪 Testing
Fixed a couple of tests due to changing from a property to an attribute. All other tests are passing.
✅ Checklist