Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor tabs component #960

Merged
merged 24 commits into from
Jan 20, 2023
Merged

Anchor tabs component #960

merged 24 commits into from
Jan 20, 2023

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Jan 12, 2023

Pull Request

🀨 Rationale

Addresses #479

πŸ‘©β€πŸ’» Implementation

  • Created nimble-anchor-tabs component with implementation starting from the FAST foundation tabs component.
  • Created nimble-anchor-tab component.
  • Updated and moved existing styling for nimble-tab into shared patterns/tab location. Shared styling used for nimble-anchor-tab, too.
  • Wrote unit tests for both new components. Because the nimble-anchor-tabs component is heavily modified from the original FAST source, I created comprehensive tests of public API and interactions.
  • Created Storybook stories
  • Updated README table

Angular and Blazor support will be in follow-up PRs

πŸ§ͺ Testing

Wrote unit tests and tested in Storybook.

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc marked this pull request as ready for review January 12, 2023 22:01
@nate-ni nate-ni mentioned this pull request Jan 13, 2023
10 tasks
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed everything except the anchor-tabs files and tests. I'll come back to those but wanted to share initial feedback.

@m-akinc m-akinc requested a review from jattasNI January 17, 2023 23:00
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to share first pass of discussion, still looking through though

@m-akinc m-akinc requested a review from rajsite January 20, 2023 15:57
@m-akinc m-akinc requested a review from rajsite January 20, 2023 19:01
@m-akinc m-akinc enabled auto-merge (squash) January 20, 2023 22:05
@m-akinc m-akinc merged commit 4c3c715 into main Jan 20, 2023
@m-akinc m-akinc deleted the users/makinc/anchor-tabs branch January 20, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants