-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anchor tabs component #960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed everything except the anchor-tabs files and tests. I'll come back to those but wanted to share initial feedback.
packages/nimble-components/src/anchor-tabs/tests/anchor-tabs.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/anchor-tabs/tests/anchor-tabs.stories.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to share first pass of discussion, still looking through though
Pull Request
π€¨ Rationale
Addresses #479
π©βπ» Implementation
nimble-anchor-tabs
component with implementation starting from the FAST foundation tabs component.nimble-anchor-tab
component.nimble-tab
into sharedpatterns/tab
location. Shared styling used fornimble-anchor-tab
, too.nimble-anchor-tabs
component is heavily modified from the original FAST source, I created comprehensive tests of public API and interactions.Angular and Blazor support will be in follow-up PRs
π§ͺ Testing
Wrote unit tests and tested in Storybook.
β Checklist