Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build combined package for 2021 32- and 64-bit builds #191

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Conversation

buckd
Copy link
Collaborator

@buckd buckd commented Nov 15, 2021

What does this Pull Request accomplish?

Combines the output of the LabVIEW 2021 32- and 64-bit builds into a single .nipkg file.

Why should this Pull Request be merged?

This is needed to install everything required for 2021 with a single package as is done for 2019 and 2020.

What testing has been done?

PR build and inspected output of all packages. This change needs Build Tools 124 to be merged before it will produce results.

@buckd buckd changed the title Dev/combined pkg Build combined package for 2021 32- and 64-bit builds Nov 23, 2021
@buckd buckd marked this pull request as ready for review November 23, 2021 21:44
@buckd buckd requested a review from Karl-G1 November 23, 2021 21:44
@Karl-G1
Copy link
Contributor

Karl-G1 commented Nov 24, 2021

@buckd @rtzoeller
I added the same package bitness settings to Scripting and Examples packages. Otherwise, the 64-bit build was producing the correct packages, then the slower 32-bit build was over-writing them with empty packages.

@Karl-G1 Karl-G1 merged commit d544e02 into main Nov 24, 2021
@Karl-G1 Karl-G1 deleted the dev/combined-pkg branch November 24, 2021 17:36
@buckd
Copy link
Collaborator Author

buckd commented Nov 29, 2021

I added the same package bitness settings to Scripting and Examples packages. Otherwise, the 64-bit build was producing the correct packages, then the slower 32-bit build was over-writing them with empty packages.

@Karl-G1 I have already created an issue for this (ni/niveristand-custom-device-build-tools#125) and should have a fix for it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants