-
Notifications
You must be signed in to change notification settings - Fork 0
feat(routes/og): add preview image generation #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicholaschiang
wants to merge
3
commits into
main
Choose a base branch
from
nicholas/og
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
b375fbc to
9b1ca9c
Compare
This patch removes the unused `images` section of the Remix configuration. Vercel will instead read this configuration from `vercel.json`. Fixes: 92e99bb ("feat: use `vercel` built-in image optimization") Ref: vercel/satori#524 (comment)
9b1ca9c to
8b123cd
Compare
8b123cd to
acb0ac0
Compare
acb0ac0 to
1de38a1
Compare
1de38a1 to
0315210
Compare
0315210 to
cc8b670
Compare
cc8b670 to
1c9f09f
Compare
This patch adds an OG image generation route for shows. It will generate an image with the show name and a preview of the first three looks in the show. This is a better experience than Vogue, in my opinion, as Vogue simply crops the first look image in an awkward manner (because the social media image aspect ratio is not very compatible with a look image ratio).
ae8c04c to
a0b5937
Compare
NC-665 Add OG images using @vercel/og
I should use the favicon for every page and then override the shows page, product page, etc. https://gist.github.com/ryanflorence/ec1849c6d690cfbffcb408ecd633e069 https://remix.run/docs/en/main/route/meta-v2#merging-with-parent-meta |
d7769dd to
d7f66e7
Compare
2bee409 to
113e7f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: NC-665