Add direct_proxy configuration variable to allow bypassing try_files #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense to have an upstream followed by =404. The @upstream parameter must be the last parameter. http://nginx.org/en/docs/http/ngx_http_core_module.html#try_files
When set to the name of an upstream, the direct_proxy variable causes
ALL requests to be proxied (so there is no try_file directive).
This is useful, for example, when proxying to a web server which handles
all static content or when the nginx reverse-proxy doesn't have access
to the origin server's root directory.
Example:
direct_proxy: apache
upstreams:
- name: apache
servers: ['apache_upstream_server']
|
Thanks a lot for this. I will hold off on merging this one, and the revamp is still quite a ways off, so it's definitely valuable to keep this around for others. |
I forgot everything in conf.d is included by the default nginx.conf file. Better to keep our configurations separate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix Issue #13:
direct_proxyvariable is introduced. When it is set to the name of an upstream, it causes ALL requests to be proxied to that upstream (so there is notry_filesdirective). This is preferable totry_fileswhen the upstream is meant to handle all requests (for example, when proxying to an Apache server that handles its own static files).In the process I moved some proxy configuration to
/etc/nginx.conf.d/common_proxy.confto reduce clutter.(Nick, I know you're currently working on a revamp of this role. I'm mostly posting this for anybody else who is using this role, and to give you ideas while you work on the new version.)