OIDC authentication #118
Open
OIDC authentication #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklaw5
requested changes
Aug 31, 2021
Owner
nicklaw5
left a comment
nicklaw5
left a comment
There was a problem hiding this comment.
We need some documentation and some mock tests if it's not too much trouble.
go.mod
Outdated
Comment on lines
6
to
9
| github.com/coreos/go-oidc v2.2.1+incompatible // indirect | ||
| github.com/coreos/go-oidc/v3 v3.0.0 // indirect | ||
| github.com/pquerna/cachecontrol v0.1.0 // indirect | ||
| golang.org/x/oauth2 v0.0.0-20210819190943-2bc19b11175f // indirect |
Owner
There was a problem hiding this comment.
This doesn't look right. Can you please run a go mod tidy to fix this.
authentication.go
Outdated
| return | ||
| } | ||
|
|
||
| func (c *Client) UserInfoFromAccessToken( |
Owner
There was a problem hiding this comment.
Suggested change
| func (c *Client) UserInfoFromAccessToken( | |
| func (c *Client) UserInfoFromOIDCAccessToken( |
Pull Request Test Coverage Report for Build 1186133813
💛 - Coveralls |
- update module name
- JWT signing - extension configuration segments endpoints - extension secrets endpoints - UPDATE extension docs
The Twitch docs are not really clear on some parts of the requests getExtensionConfiguration: - broadcasterID is an optional query parameter setExtensionConfiguration: - broadcasterId is an optional body parameter - validate the segment type if broadcasterID is provided MISC: - update 'GetExtensionSecret' -> 'GetExtensionSecrets'
The response contains a json field 'total' which we're not currently unmarshalling to create event subs
- Extension Live Channels - Unit test for Extension Live Channels - Supported Endpoints
https://dev.twitch.tv/docs/api/reference#send-chat-announcement - add api parameters, response, func to chat.go - add unit tests
https://dev.twitch.tv/docs/api/reference#send-chat-announcement - add api parameters, response, func to chat.go - add unit tests
- add prefix of '/' to the charity campaigns url
- Twitch user claims struct - IDToken struct - OIDC auth struct - Request user OIDC access token - UserInfo endpoint from access token
- oidc provider as interface - refactor auth url to default url - fetch auth url and oidc provider from opts of client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Twitch OIDC authentication to Helix.