-
Notifications
You must be signed in to change notification settings - Fork 96
feat: Add SubscriptionID to EventSubSubscriptionsParams #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EventSubSubscriptionsParams comment
|
Update the tests! |
|
added test for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for filtering EventSub subscriptions by SubscriptionID and clarifies that filter parameters are mutually exclusive.
- Adds a new
SubscriptionIDfield toEventSubSubscriptionsParamsstruct - Updates documentation to clarify that filters are mutually exclusive (except
After) - Adds test coverage for both error case (multiple filters) and success case (subscription ID filtering)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eventsub.go | Adds SubscriptionID field to filter parameters, updates comment to clarify mutual exclusivity, removes extra blank line |
| eventsub_test.go | Adds test cases for bad request when multiple filters are specified and successful subscription ID lookup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Pull Request Test Coverage Report for Build 19191202170Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
related issue: #240