Update emptyExtensions rule to support @retroactive extensions (#1943)

nicklockwood · Dec 22, 2024 · 112174a · 112174a
1 parent 332e1cd
commit 112174a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/Sources/ParsingHelpers.swift b/Sources/ParsingHelpers.swift
@@ -1271,8 +1271,10 @@ extension Formatter {
     ///  - `some ...`
     ///  - `borrowing ...`
     ///  - `consuming ...`
+    ///  - `sending ...`
     ///  - `@escaping ...`
     ///  - `@unchecked ...`
+    ///  - `@retroactive ...`
     ///  - `~...`
     ///  - `(type).(type)`
     ///  - `(type) & (type)`
@@ -1386,9 +1388,9 @@ extension Formatter {
             return (name: tokens[typeRange].stringExcludingLinebreaks, range: typeRange)
         }
 
-        // Parse types of the form `any ...`, `some ...`, `borrowing ...`, `consuming ...`,
-        // `@unchecked ...`, `@escaping ...`, `~...`,
-        let typePrefixes = Set(["any", "some", "borrowing", "consuming", "@unchecked", "@escaping", "~"])
+        // Parse types of the form `any ...`, `some ...`, `borrowing ...`, `consuming ...`, `sending ...`,
+        // `@unchecked ...`, `@escaping ...`, `~...`, `@retroactive ...`,
+        let typePrefixes = Set(["any", "some", "borrowing", "consuming", "sending", "@unchecked", "@escaping", "~", "@retroactive"])
         if typePrefixes.contains(startToken.string),
            let nextToken = index(of: .nonSpaceOrCommentOrLinebreak, after: startOfTypeIndex),
            let followingType = parseType(at: nextToken)

diff --git a/Tests/Rules/EmptyExtensionsTests.swift b/Tests/Rules/EmptyExtensionsTests.swift
@@ -35,6 +35,9 @@ class EmptyExtensionsTests: XCTestCase {
     func testDoNotRemoveEmptyConformingExtension() {
         let input = """
         extension String: Equatable {}
+        extension Foo: @unchecked Sendable {}
+        extension Bar: @retroactive @unchecked Sendable {}
+        extension Module.Bar: @retroactive @unchecked Swift.Sendable {}
         """
         testFormatting(for: input, rule: .emptyExtensions)
     }