-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trigger for release action from created
to published
#1730
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1730 +/- ##
==========================================
- Coverage 95.19% 95.14% -0.06%
==========================================
Files 20 20
Lines 22882 22882
==========================================
- Hits 21783 21771 -12
- Misses 1099 1111 +12 ☔ View full report in Codecov by Sentry. |
Also noticed that the output artifact bundle doesn't seem to support Intel, probably because the |
Confirmed that change fixed Intel support: airbnb/swift#275. Our style guide repo / formatter tool now uses an artifact bundle created by this CI job. |
…fix Intel x86_64 support (#1730)
…fix Intel x86_64 support (#1730)
…fix Intel x86_64 support (#1730)
…fix Intel x86_64 support (#1730)
…fix Intel x86_64 support (#1730)
…fix Intel x86_64 support (#1730)
…fix Intel x86_64 support (#1730)
…fix Intel x86_64 support (#1730)
…fix Intel x86_64 support (#1730)
…fix Intel x86_64 support (#1730)
Looks like this worked for 0.54.2! https://github.com/nicklockwood/SwiftFormat/actions/runs/10037568602 |
The release new action from #1721 didn't trigger properly for 0.54.0.
Right now the job uses a
release: [created]
trigger. The documentation says:This is probably the most likely explanation for why it didn't work.
It sounds like the recommended trigger is
published
rather thancreated
:so this PR updates the trigger. Hopefully now it'll work for 0.54.1!