Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trigger for release action from created to published #1730

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

calda
Copy link
Collaborator

@calda calda commented Jun 12, 2024

The release new action from #1721 didn't trigger properly for 0.54.0.

Right now the job uses a release: [created] trigger. The documentation says:

Note: Workflows are not triggered for the created, edited, or deleted activity types for draft releases. When you create your release through the GitHub browser UI, your release may automatically be saved as a draft.

This is probably the most likely explanation for why it didn't work.

It sounds like the recommended trigger is published rather than created:

on:
  release:
    types: [published]

so this PR updates the trigger. Hopefully now it'll work for 0.54.1!

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (dd989a4) to head (fa9e3e2).

Current head fa9e3e2 differs from pull request most recent head d39b6b8

Please upload reports for the commit d39b6b8 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1730      +/-   ##
==========================================
- Coverage   95.19%   95.14%   -0.06%     
==========================================
  Files          20       20              
  Lines       22882    22882              
==========================================
- Hits        21783    21771      -12     
- Misses       1099     1111      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@calda
Copy link
Collaborator Author

calda commented Jun 12, 2024

Also noticed that the output artifact bundle doesn't seem to support Intel, probably because the --arch argument was wrong.

@calda calda changed the base branch from main to develop June 12, 2024 17:58
@calda calda merged commit 9a4258e into develop Jun 12, 2024
10 checks passed
@calda calda deleted the cal--fix-release-action-trigger branch June 12, 2024 18:06
@calda
Copy link
Collaborator Author

calda commented Jun 12, 2024

Confirmed that change fixed Intel support: airbnb/swift#275. Our style guide repo / formatter tool now uses an artifact bundle created by this CI job.

nicklockwood pushed a commit that referenced this pull request Jun 18, 2024
nicklockwood pushed a commit that referenced this pull request Jun 23, 2024
nicklockwood pushed a commit that referenced this pull request Jun 23, 2024
nicklockwood pushed a commit that referenced this pull request Jun 29, 2024
nicklockwood pushed a commit that referenced this pull request Jun 29, 2024
nicklockwood pushed a commit that referenced this pull request Jun 29, 2024
nicklockwood pushed a commit that referenced this pull request Jul 10, 2024
nicklockwood pushed a commit that referenced this pull request Jul 10, 2024
nicklockwood pushed a commit that referenced this pull request Jul 20, 2024
nicklockwood pushed a commit that referenced this pull request Jul 22, 2024
@calda
Copy link
Collaborator Author

calda commented Jul 22, 2024

Looks like this worked for 0.54.2! https://github.com/nicklockwood/SwiftFormat/actions/runs/10037568602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant