Repository navigation
Conversation
When honcho's stdout is piped and the consumer exits early, print() raises BrokenPipeError and aborts the manager loop before child processes are terminated. Catch it so shutdown can proceed. Fixes nickstenning#255
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When honcho's stdout is piped and the consumer exits early (e.g.
honcho start | head/| teethen Ctrl-C),Printer.writeraisesBrokenPipeErrorfromprint()and aborts the manager loop before child processes are terminated. That can leave children running and subsequent restarts fail with address already in use.Catch
BrokenPipeErrorinPrinter.writeand return so shutdown can proceed, matching the approach suggested in #255 / the Python SIGPIPE note.Fixes #255.
Test plan
pytest tests/test_printer.py— 16 passed (includes newtest_write_broken_pipe_is_swallowed)