Skip to content

fix: harden install-pi.sh and share.sh against supply-chain and data-exposure risks #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaolai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: harden install-pi.sh and share.sh against supply-chain and data-exposure risks #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions install-pi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ cp -r plugins/visual-explainer "$SKILL_DIR"
# Replace {{skill_dir}} with actual path
echo "Patching paths..."
if [[ "$OSTYPE" == "darwin"* ]]; then
find "$SKILL_DIR" -name "*.md" -exec sed -i '' "s|{{skill_dir}}|$SKILL_DIR|g" {} \;
find "$SKILL_DIR" -name "*.md" -exec sed -i '' "s#{{skill_dir}}#$SKILL_DIR#g" {} \;
else
find "$SKILL_DIR" -name "*.md" -exec sed -i "s|{{skill_dir}}|$SKILL_DIR|g" {} \;
find "$SKILL_DIR" -name "*.md" -exec sed -i "s#{{skill_dir}}#$SKILL_DIR#g" {} \;
fi

# Copy prompts (slash commands)
Expand Down
1 change: 1 addition & 0 deletions plugins/visual-explainer/scripts/share.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ trap 'rm -rf "$TEMP_DIR"' EXIT
cp "$HTML_FILE" "$TEMP_DIR/index.html"

echo -e "${CYAN}Sharing $(basename "$HTML_FILE")...${NC}" >&2
echo -e "⚠ Deployment is PUBLIC — anyone with the URL can view this file." >&2

# Deploy via vercel-deploy skill
# Temporarily disable errexit to capture deployment errors
Expand Down