Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored webui* rules #2954

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

ariel-anieli
Copy link

Description

Refactored webui* rules

Resume

# git log --oneline -n1 --pretty=short
commit f2f97e2f (HEAD -> makefile)
Author: Ariel Otilibili <[email protected]>

    Refactored `webui*` rules

# make webui -n >> /tmp/makefile; echo $?
0

# make webui-audit -n >> /tmp/makefile; echo $?
0

# make webui-audit-fix -n >> /tmp/makefile; echo $?
0

# git switch develop
Switched to branch 'develop'
Your branch is up to date with 'origin/develop'.

# git log --oneline -n1 --pretty=short
commit 24c87253 (HEAD -> develop, origin/develop, origin/HEAD)
Merge: 42af55b3 fa7fc5bd
Author: Nicolas Hennion <[email protected]>

    Merge pull request #2941 from ariel-anieli/refactor-alert

# make webui -n >> /tmp/develop; echo $?
0

# make webui-audit -n >> /tmp/develop; echo $?
0

# make webui-audit-fix -n >> /tmp/develop; echo $?
0

# diff /tmp/develop /tmp/makefile; echo $?
0

* part of nicolargo#2906
* output is unchanged.

```
$ git log --oneline -n1 --pretty=short
commit f2f97e2f (HEAD -> makefile)
Author: Ariel Otilibili <[email protected]>

    Refactored `webui*` rules

$ make webui -n >> /tmp/makefile; echo $?
0

$ make webui-audit -n >> /tmp/makefile; echo $?
0

$ make webui-audit-fix -n >> /tmp/makefile; echo $?
0

$ git switch develop
Switched to branch 'develop'
Your branch is up to date with 'origin/develop'.

$ git log --oneline -n1 --pretty=short
commit 24c8725 (HEAD -> develop, origin/develop, origin/HEAD)
Merge: 42af55b fa7fc5b
Author: Nicolas Hennion <[email protected]>

    Merge pull request nicolargo#2941 from ariel-anieli/refactor-alert

$ make webui -n >> /tmp/develop; echo $?
0

$ make webui-audit -n >> /tmp/develop; echo $?
0

$ make webui-audit-fix -n >> /tmp/develop; echo $?
0

$ diff /tmp/develop /tmp/makefile; echo $?
0
```

Signed-off-by: Ariel Otilibili <[email protected]>
@nicolargo
Copy link
Owner

Thanks a lot @ariel-anieli

@nicolargo nicolargo merged commit 7ab8a39 into nicolargo:develop Oct 2, 2024
15 of 16 checks passed
@ariel-anieli ariel-anieli deleted the makefile branch October 2, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants