Decouple logic from interactive grid component #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nicolasperez19#16 Decouple logic from the interactive grid component. * Add `src/utils/micLogic.ts` to export functions for handling microphone positions, zoom, pan, modes, mouse interactions, coordinate conversions, and numpy array string generation. * Modify `src/components/MicMasterFlex.tsx` to import functions from `src/utils/micLogic.ts` and replace state management, event handlers, and numpy array string generation with utility functions. * Add `src/utils/micLogic.test.ts` to test handling microphone positions, zoom, pan, modes, mouse interactions, coordinate conversions, and numpy array string generation. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/nicolasperez19/mic-master-flex/issues/16?shareId=XXXX-XXXX-XXXX-XXXX).
Fixes nicolasperez19#23 Add Lighthouse audit to CI workflow. * **package.json**: - Add `lighthouse-ci` as a dev dependency. - Add a new script `lighthouse` to run Lighthouse CI. * **.github/workflows/deploy.yml**: - Add a new job `lighthouse` to run Lighthouse audit after the `build` job. - Use `actions/setup-node@v3` to set up Node.js. - Run `npm install` and `npm run lighthouse` in the `lighthouse` job. * **README.md**: - Add a section about Lighthouse audit in the CI process. - Include instructions for running Lighthouse CI locally. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/nicolasperez19/mic-master-flex/issues/23?shareId=XXXX-XXXX-XXXX-XXXX).
Fixes #2 Add keyboard shortcuts for changing between add, edit, delete functionality. * **MicMasterFlex.tsx** - Import `useEffect` from React. - Add `useEffect` to handle keyboard event listeners for mode changes. - Add event listener for 'keydown' event to switch modes based on key pressed ('1' for Pan, '2' for Add, '3' for Edit, '4' for Delete). - Add cleanup function to remove event listeners on component unmount. * **README.md** - Add section to document new keyboard shortcuts for changing modes. - Update table of contents to include the new section on keyboard shortcuts. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/nicolasperez19/mic-master-flex/issues/2?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
Decouple logic from the interactive grid component.
src/utils/micLogic.tsto export functions for handling microphone positions, zoom, pan, modes, mouse interactions, coordinate conversions, and numpy array string generation.src/components/MicMasterFlex.tsxto import functions fromsrc/utils/micLogic.tsand replace state management, event handlers, and numpy array string generation with utility functions.src/utils/micLogic.test.tsto test handling microphone positions, zoom, pan, modes, mouse interactions, coordinate conversions, and numpy array string generation.For more details, open the Copilot Workspace session.