refactor(desktop): remove restic bridge#1012
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f687732f9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| MIGRATIONS_PATH: path.join(dirs.resourcesDir, "assets", "migrations"), | ||
| RESTIC_COMMAND: path.join(binDir, "zerobyte-restic.ts"), | ||
| ZEROBYTE_DESKTOP_RESTIC_BRIDGE_URL: resticBridge.url, | ||
| RESTIC_COMMAND: path.join(binDir, "restic"), |
There was a problem hiding this comment.
After packaged desktop builds run restic directly from the Bun server, runtime.stop() still only terminates the server process. I checked the server/restic spawning path and there is no SIGTERM handler that aborts active safeSpawn controllers, so quitting the desktop app during a backup or restore can leave the restic grandchild running after the UI/server exit and holding repository locks. The removed bridge tracked and killed active restic children; an equivalent shutdown path is needed here.
Useful? React with 👍 / 👎.
1 participant
No description provided.