direct url downloading update

[ShiiRochi]

It relates to the issue #8

In case of allowDownloadByUrl being set to true, code will set target as '_blank' to 'a' element and will not revokeUrlObject, because it is not created in this case.

[nielsboogaard]

Hi @ShiiRochi, thanks for the PR. Could you do a catchup with the master branch and rebuild the distribution again to get rid of the merge conflicts? After that I'm happy to merge it.

[ShiiRochi]

Okay

[ShiiRochi]

Hi, @nielsboogaard, I've just fixed conflicts and rebuilt dist.

[virtualize]

Hello @nielsboogaard, could you please merge this PR or is there anything preventing you I could possible help with?

[nielsboogaard]

@virtualize Sorry for my late reply, was quite busy with other things. I'll have a look at your PR next week, and will merge it when it works ok. Thanks for the work (and your patience 😉 )!

[cenkakay]

any updates?

[ShiiRochi]

any updates?

It seems that I need to make another rebase to resolve conflicts again 🙃

[ShiiRochi]

any updates?

It seems that I need to make another rebase to resolve conflicts again 🙃

done)

[ShiiRochi]

I'm currently not working with this component so often anymore, an as far as I saw into code a third argument was added - downloadFunction, maybe it can be used to download file directly. No matter what, I updated my changes so that this MR can be either rejected or accepted. If there're some points that are questionable, then @nielsboogaard can write and I will try to adjust them.

But if this changes are not required and can be replaced by using downloadFunction argument, then this MR can be closed.

[nielsboogaard]

Sorry for keeping this open so long, and thanks for your patience. Just reviewed the PR, looks fine so will merge it.