Allow to set media element options via mediaElementAttributes option #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiiRochi
changed the title
|
The idea of that PR has come to me after I've implemented video upload on a project I'm working on now, where I want to hide controls, as soon as they are duplicating already existing video previewing functionality. |
ShiiRochi
force-pushed
the
video-element-attributes
branch
from
ffc26e0
to
9c62697
Compare
ShiiRochi
force-pushed
the
video-element-attributes
branch
from
9c62697
to
82df148
Compare
ShiiRochi
force-pushed
the
video-element-attributes
branch
from
b945fb3
to
206fb88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! In this PR, I've added mediaElementAttributes option. Inside createMediaView, hope to correctly reference to it, mediaElementAttributes is queried and is used to setAttributes to a newly created media element.