Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address pending dual-funding PR comments #6

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Address pending dual-funding PR comments #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b62abed
Address pending PR comments
t-bast Oct 19, 2022
f2daadb
fixup! Address pending PR comments
t-bast Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions 01-messaging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,19 +342,19 @@ For simplicity of diagnosis, it's often useful to tell a peer that something is

The channel is referred to by `channel_id`, unless `channel_id` is 0 (i.e. all bytes are 0), in which case it refers to all channels.

The funding node using channel establishment v1 `open_channel`:
The funding node using channel establishment v1 (`open_channel`):
- for all error messages sent before (and including) the `funding_created` message:
- MUST use `temporary_channel_id` in lieu of `channel_id`.

The fundee node using channel establishment v1 (`accept_channel`):
- for all error messages sent before (and not including) the `funding_signed` message:
- MUST use `temporary_channel_id` in lieu of `channel_id`.

The opener node using channel establishment v2 `open_channel2`:
The opener node using channel establishment v2 (`open_channel2`):
- for all error messages sent before the `accept_channel2` message is received:
- MUST use `temporary_channel_id` in lieu of `channel_id`.

The accepter node using channel establishment v2 `open_channel2`:
The accepter node using channel establishment v2 (`open_channel2`):
- for all error messages sent before (and including) the `accept_channel2` message:
- MUST use `temporary_channel_id` in lieu of `channel_id`.

Expand Down
Loading