Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony 7 support #92

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

niels-nijens
Copy link
Member

@niels-nijens niels-nijens commented Apr 9, 2024

Adds Symfony 7 support to the ProblemExceptionNormalizer while maintaining backward compatibility with lower Symfony and PHP versions.

Copy link

github-actions bot commented Apr 9, 2024

Code Coverage Report:
2024-04-09 14:10:22

Summary:
Classes: 73.33% (22/30)
Methods: 91.67% (132/144)
Lines: 97.52% (786/806)

Nijens\OpenapiBundle\Controller\CatchAllController
Methods: 100.00% ( 4/ 4) Lines: 100.00% ( 30/ 30)
Nijens\OpenapiBundle\DependencyInjection\Configuration
Methods: 100.00% ( 4/ 4) Lines: 100.00% ( 83/ 83)
Nijens\OpenapiBundle\DependencyInjection\NijensOpenapiExtension
Methods: 40.00% ( 2/ 5) Lines: 77.78% ( 21/ 27)
Nijens\OpenapiBundle\DependencyInjection\ServiceFactory
Methods: 0.00% ( 0/ 1) Lines: 60.00% ( 3/ 5)
Nijens\OpenapiBundle\Deserialization\ArgumentResolver\DeserializedObjectArgumentResolver
Methods: 60.00% ( 3/ 5) Lines: 90.91% ( 20/ 22)
Nijens\OpenapiBundle\Deserialization\Attribute\DeserializedObject
Methods: ( 0/ 0) Lines: ( 0/ 0)
Nijens\OpenapiBundle\Deserialization\DeserializationContext
Methods: ( 0/ 0) Lines: ( 0/ 0)
Nijens\OpenapiBundle\Deserialization\EventSubscriber\JsonRequestBodyDeserializationSubscriber
Methods: 100.00% ( 3/ 3) Lines: 100.00% ( 20/ 20)
Nijens\OpenapiBundle\ExceptionHandling\EventSubscriber\ProblemExceptionToJsonResponseSubscriber
Methods: 66.67% ( 2/ 3) Lines: 93.75% ( 15/ 16)
Nijens\OpenapiBundle\ExceptionHandling\EventSubscriber\ThrowableToProblemExceptionSubscriber
Methods: 75.00% ( 3/ 4) Lines: 93.75% ( 15/ 16)
Nijens\OpenapiBundle\ExceptionHandling\Exception\InvalidContentTypeProblemException
Methods: ( 0/ 0) Lines: ( 0/ 0)
Nijens\OpenapiBundle\ExceptionHandling\Exception\InvalidRequestBodyProblemException
Methods: ( 0/ 0) Lines: ( 0/ 0)
Nijens\OpenapiBundle\ExceptionHandling\Exception\InvalidRequestParameterProblemException
Methods: ( 0/ 0) Lines: ( 0/ 0)
Nijens\OpenapiBundle\ExceptionHandling\Exception\InvalidRequestProblemException
Methods: 100.00% ( 5/ 5) Lines: 100.00% ( 12/ 12)
Nijens\OpenapiBundle\ExceptionHandling\Exception\ProblemException
Methods: 100.00% (16/16) Lines: 100.00% ( 55/ 55)
Nijens\OpenapiBundle\ExceptionHandling\Exception\Violation
Methods: 100.00% ( 6/ 6) Lines: 100.00% ( 16/ 16)
Nijens\OpenapiBundle\ExceptionHandling\Normalizer\AbstractProblemExceptionNormalizer
Methods: 66.67% ( 4/ 6) Lines: 84.62% ( 22/ 26)
Nijens\OpenapiBundle\ExceptionHandling\Normalizer\ProblemExceptionNormalizer
Methods: 100.00% ( 1/ 1) Lines: 100.00% ( 1/ 1)
Nijens\OpenapiBundle\ExceptionHandling\ThrowableToProblemExceptionTransformer
Methods: 100.00% ( 3/ 3) Lines: 100.00% ( 18/ 18)
Nijens\OpenapiBundle\Json\Dereferencer
Methods: 100.00% ( 6/ 6) Lines: 100.00% ( 43/ 43)
Nijens\OpenapiBundle\Json\Exception\InvalidArgumentException
Methods: ( 0/ 0) Lines: ( 0/ 0)
Nijens\OpenapiBundle\Json\Exception\InvalidJsonPointerException
Methods: ( 0/ 0) Lines: ( 0/ 0)
Nijens\OpenapiBundle\Json\Exception\LoaderLoadException
Methods: ( 0/ 0) Lines: ( 0/ 0)
Nijens\OpenapiBundle\Json\JsonPointer
Methods: 100.00% (11/11) Lines: 100.00% ( 39/ 39)
Nijens\OpenapiBundle\Json\Loader\ChainLoader
Methods: 100.00% ( 3/ 3) Lines: 100.00% ( 9/ 9)
Nijens\OpenapiBundle\Json\Loader\JsonLoader
Methods: 100.00% ( 2/ 2) Lines: 100.00% ( 7/ 7)
Nijens\OpenapiBundle\Json\Loader\YamlLoader
Methods: 100.00% ( 2/ 2) Lines: 100.00% ( 4/ 4)
Nijens\OpenapiBundle\Json\Reference
Methods: 100.00% (11/11) Lines: 100.00% ( 24/ 24)
Nijens\OpenapiBundle\Json\SchemaLoader
Methods: 100.00% ( 3/ 3) Lines: 100.00% ( 10/ 10)
Nijens\OpenapiBundle\Json\Schema\Constraint\TypeConstraint
Methods: 100.00% ( 1/ 1) Lines: 100.00% ( 8/ 8)
Nijens\OpenapiBundle\NijensOpenapiBundle
Methods: 50.00% ( 1/ 2) Lines: 77.78% ( 7/ 9)
Nijens\OpenapiBundle\Routing\RouteContext
Methods: ( 0/ 0) Lines: ( 0/ 0)
Nijens\OpenapiBundle\Routing\RouteLoader
Methods: 100.00% (10/10) Lines: 100.00% (104/104)
Nijens\OpenapiBundle\Serialization\SerializationContextBuilder
Methods: 85.71% ( 6/ 7) Lines: 97.87% ( 46/ 47)
Nijens\OpenapiBundle\Validation\EventSubscriber\RequestValidationSubscriber
Methods: 100.00% ( 4/ 4) Lines: 100.00% ( 13/ 13)
Nijens\OpenapiBundle\Validation\RequestValidator\CompositeRequestValidator
Methods: 100.00% ( 2/ 2) Lines: 100.00% ( 6/ 6)
Nijens\OpenapiBundle\Validation\RequestValidator\RequestBodyValidator
Methods: 100.00% ( 7/ 7) Lines: 100.00% ( 64/ 64)
Nijens\OpenapiBundle\Validation\RequestValidator\RequestContentTypeValidator
Methods: 100.00% ( 3/ 3) Lines: 100.00% ( 26/ 26)
Nijens\OpenapiBundle\Validation\RequestValidator\RequestParameterValidator
Methods: 100.00% ( 4/ 4) Lines: 100.00% ( 42/ 42)
Nijens\OpenapiBundle\Validation\ValidationContext
Methods: ( 0/ 0) Lines: ( 0/ 0)

@niels-nijens niels-nijens marked this pull request as ready for review April 9, 2024 14:14
@niels-nijens niels-nijens merged commit 0c282f5 into nijens:main Apr 9, 2024
27 checks passed
@niels-nijens niels-nijens deleted the add-symfony-7-support branch April 9, 2024 14:14
@niels-nijens niels-nijens added this to the 2.0 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant