Skip to content

make group member list a BTreeSet#16

Merged
nikstur merged 1 commit intonikstur:mainfrom
Mic92:hash-set
Feb 1, 2025
Merged

make group member list a BTreeSet#16
nikstur merged 1 commit intonikstur:mainfrom
Mic92:hash-set

Conversation

@Mic92
Copy link
Copy Markdown
Contributor

@Mic92 Mic92 commented Feb 1, 2025

vec::dedup() won't work if the input is not sorted.

vec::dedup() won't work if the input is not sorted.
Comment thread rust/userborn/src/main.rs
root:x:0:root
initial:x:998:initial
wheel:x:999:normalo,initial
wheel:x:999:initial,normalo
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those has to be sorted now. But I have to say having reproducible order in this file is nicer anyway.

@Mic92 Mic92 changed the title make group member list a hashset make group member list a BTreeSet Feb 1, 2025
Copy link
Copy Markdown
Owner

@nikstur nikstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is definitely the way to go!

@nikstur nikstur merged commit f0ec54a into nikstur:main Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants